fix: persist Mesh Radio off across foreground/BLE events (#71) - #75
Open
chtnnh wants to merge 3 commits into
Open
fix: persist Mesh Radio off across foreground/BLE events (#71)#75chtnnh wants to merge 3 commits into
chtnnh wants to merge 3 commits into
Conversation
Store deliberate off in SecureStore and only auto-start when BLE is ready and the user has not turned the radio off, so unlock/foreground cannot silently resume advertising. Co-authored-by: Cursor <cursoragent@cursor.com>
CI's `npx expo install --check` started failing after upstream SDK 57 patch bumps (expo ~57.0.8 and related packages). Co-authored-by: Cursor <cursoragent@cursor.com>
Lock @napi-rs/wasm-runtime's @emnapi/core and @emnapi/runtime peers at the top level so CI's npm ci does not demand an unlocked 1.11.2. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
protestchat.radioEnabled.v1) in SecureStore.RadioAccessGateauto-starts only viashouldAutoStartRadio(bleReady, userEnabled)— a deliberate Settings off survives AppState/BLE status events.startRadio/stopRadiowrite the preference; panic wipe resets to on with the fresh identity.Closes #71
Test plan
npm test/npm run typecheck(shouldAutoStartRadiocases)