fix: reject oversized envelopes at decode (#72) - #76
Open
chtnnh wants to merge 3 commits into
Open
Conversation
Mirror encodeEnvelope's payload ceiling in decodeEnvelope so hostile frames under the native 32 KiB reassembly cap cannot trial-decrypt then throw in storeEnvelope. Swallow encode failures in store and catch ingest. Co-authored-by: Cursor <cursoragent@cursor.com>
CI's `npx expo install --check` started failing after upstream SDK 57 patch bumps (expo ~57.0.8 and related packages). Co-authored-by: Cursor <cursoragent@cursor.com>
Lock @napi-rs/wasm-runtime's @emnapi/core and @emnapi/runtime peers at the top level so CI's npm ci does not demand an unlocked 1.11.2. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decodeEnveloperejectspayloadLen > MAX_ENVELOPE_LEN - HEADER_LEN(same bound as encode).storeEnvelope(SQL + memory) catches encode failures instead of throwing..catch()s ingest so residual failures cannot surface as unhandled rejections.Closes #72
Test plan
npm test/npm run typecheck(oversized decode + storeEnvelope swallow)