fix: propagate reader options to Hadoop conf in driver paths#1040
Open
josecsotomorales wants to merge 2 commits into
Open
fix: propagate reader options to Hadoop conf in driver paths#1040josecsotomorales wants to merge 2 commits into
josecsotomorales wants to merge 2 commits into
Conversation
The V2 scan path already builds its Hadoop Configuration with `newHadoopConfWithOptions(...)`, but driver-side schema inference (`ExcelTable.inferSchema`) and the V1 read/write relations in `DefaultSource` still used plain `newHadoopConf()`. As a result, reader options such as bucket-scoped `fs.s3a.*` credentials passed via `DataFrameReader.options(...)` were ignored on the driver, causing Excel reads to fail during inference before executors got a chance to apply the scoped options. Use `newHadoopConfWithOptions` in all three sites so every Hadoop `Configuration` created by spark-excel sees the option map. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
fix: propagate reader options to Hadoop conf in driver paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The V2 scan path already builds its Hadoop Configuration with
newHadoopConfWithOptions(...), but driver-side schema inference(
ExcelTable.inferSchema) and the V1 read/write relations inDefaultSourcestill used plainnewHadoopConf(). As a result,reader options such as bucket-scoped
fs.s3a.*credentials passedvia
DataFrameReader.options(...)were ignored on the driver,causing Excel reads to fail during inference before executors got
a chance to apply the scoped options.
Use
newHadoopConfWithOptionsin all three sites so every HadoopConfigurationcreated by spark-excel sees the option map.