check for NUL in filename after applying unicode path extra field - #570
Open
arshsmith1 wants to merge 1 commit into
Open
arshsmith1 wants to merge 1 commit into
arshsmith1 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NUL byte check on entry names in _zip_dirent_read runs before the Info-ZIP Unicode Path extra field (0x7075) can replace the name, so a matching-CRC extra field carrying a valid but non-ASCII UTF-8 payload with an embedded U+0000 slips a NUL into the name and an archive opened with ZIP_CHECKCONS is accepted. Callers that then treat the name as a C string see it truncated at the NUL. Move the check so it runs on the final name, after the extra field is applied. Includes a regress test that opens a crafted archive with -c and expects rejection.