Allow multiple entries for app_id in 'on-window-detected' block - #1665
Open
thapakazi wants to merge 3 commits into
Open
Allow multiple entries for app_id in 'on-window-detected' block#1665thapakazi wants to merge 3 commits into
thapakazi wants to merge 3 commits into
Conversation
nikitabobko
force-pushed
the
main
branch
2 times, most recently
from
November 24, 2025 01:31
f324d2e to
7aff813
Compare
|
This was kindly added due to my Feature Request (#660 (comment)). It looks fine, why doesnt it get merged @nikitabobko ? |
vitorebatista
added a commit
to vitorebatista/AeroSpace-edge
that referenced
this pull request
Jun 2, 2026
Ports nikitabobko#1665. if.app-id now accepts a string or an array of bundle IDs. Stored as appIds with a backward-compatible appId computed property; the matcher checks membership via contains. Re-implemented for the fork's Json/ConfigBacktrace/ParsedConfig parser API (parseAppIds lives in parseOnWindowDetected.swift) and the fork's CaseInsensitiveRegex / rawAppBundleId APIs. The unrelated node_modules .gitignore change from upstream was intentionally dropped. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nikitabobko
added
the
not-actionable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Add array support for app-id on on-window-detect block
Currently, we have to write:
With this change we can write:
Issue: #660
PR checklist
Kinda new to Swift, please let me know if anything additional needed for this. Thanks 🙏