Skip to content

adds nimPreviewCStringComparisons for cstring comparisons #24946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2025
Merged

adds nimPreviewCStringComparisons for cstring comparisons #24946

merged 2 commits into from
May 14, 2025
+32 −26

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented May 11, 2025 •
edited
Loading

todo: We can also give a deprecation message for ltPtr/lePtr matching for cstring in magicsAfterOverloadResolution

follow up #24942

@Araq Araq merged commit ade500b into devel May 14, 2025
18 checks passed
@Araq Araq deleted the pr_un_cstring branch May 14, 2025 19:31
@github-actions GitHub Actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from ade500b

Hint: mm: orc; opt: speed; options: -d:release
179787 lines; 8.383s; 660.031MiB peakmem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ringabout @Araq