Parse null,true/false directly from the buffer, avoid copying#25492
Open
planetis-m wants to merge 1 commit intonim-lang:develfrom
Open
Parse null,true/false directly from the buffer, avoid copying#25492planetis-m wants to merge 1 commit intonim-lang:develfrom
planetis-m wants to merge 1 commit intonim-lang:develfrom
Conversation
arnetheduck
reviewed
Feb 9, 2026
| my.bufpos = pos | ||
| proc parseKeyword(my: var JsonParser): TokKind = | ||
| let pos = my.bufpos | ||
| case my.buf[pos] |
Contributor
There was a problem hiding this comment.
what happens when my.buf.len <= pos + len(match)?
Contributor
Author
There was a problem hiding this comment.
Good question, I suppose it reads the terminating character and works correctly.
Contributor
There was a problem hiding this comment.
... or, more likely, [] raises a defect?
Contributor
Author
There was a problem hiding this comment.
I think the way this parser is built and also looking at lexbase.nim, it makes the assumption that [] doesnt perform range checks.
Contributor
There was a problem hiding this comment.
ah, I see 👍 there's an extra non-ident character injected always, it seems so although [] performs a range check it should not be violated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.