See discussion at https://github.com/nim-lang/Nim/pull/25602 .#25612
Merged
Araq merged 1 commit intonim-lang:develfrom Mar 19, 2026
Merged
See discussion at https://github.com/nim-lang/Nim/pull/25602 .#25612Araq merged 1 commit intonim-lang:develfrom
Araq merged 1 commit intonim-lang:develfrom
Conversation
Contributor
Author
|
Yesterday's Issue #25608 also relates. |
Contributor
Author
|
This PR also passes the CI fine as per the auto-report green check. :-) It also works, as one might expect from such a small change. E.g., for me |
Contributor
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems in dispute whether changes to code induced to avoid this new warning firing are worthwhile.
Until either the analyzer is better or a palatable way to adjust stdlib code not warn is found, verbosity=1 should not include the warning.
Possibly higher levels, too, but this PR is conservative and only takes it out at the 2->1 transition.