Skip to content

See discussion at https://github.com/nim-lang/Nim/pull/25602 .#25612

Merged
Araq merged 1 commit intonim-lang:develfrom
c-blake:ImplicitRangeConversionOffInVerbosity1
Mar 19, 2026
Merged

See discussion at https://github.com/nim-lang/Nim/pull/25602 .#25612
Araq merged 1 commit intonim-lang:develfrom
c-blake:ImplicitRangeConversionOffInVerbosity1

Conversation

@c-blake
Copy link
Contributor

@c-blake c-blake commented Mar 16, 2026

It seems in dispute whether changes to code induced to avoid this new warning firing are worthwhile.

Until either the analyzer is better or a palatable way to adjust stdlib code not warn is found, verbosity=1 should not include the warning.

Possibly higher levels, too, but this PR is conservative and only takes it out at the 2->1 transition.

@c-blake
Copy link
Contributor Author

c-blake commented Mar 17, 2026

Yesterday's Issue #25608 also relates.

@c-blake
Copy link
Contributor Author

c-blake commented Mar 18, 2026

This PR also passes the CI fine as per the auto-report green check. :-) It also works, as one might expect from such a small change.

E.g., for me nim c --verbosity=2 lib/pure/random.nim produces 1364 lines of 263 ImplicitRangeConversion diagnostics at 141 distinct code locations, although almost all are in imported modules like std/unicode and std/times. Meanwhile, at verbosity=1 the same is just a few UnusedImport and Deprecated and 1 ImplicitDefaultValue in std/times.

@Araq Araq merged commit 4bf44ca into nim-lang:devel Mar 19, 2026
18 checks passed
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 4bf44ca

Hint: mm: orc; opt: speed; options: -d:release
189893 lines; 9.456s; 802.473MiB peakmem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants