Skip to content

Use @nimblehq/stylelint-config-nimble and @nimblehq/eslint-config-nimble #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
andyduong1920 wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Use @nimblehq/stylelint-config-nimble and @nimblehq/eslint-config-nimble #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2e134f
Use @nimblehq/stylelint-config-nimble and @nimblehq/eslint-config-nimble
andyduong1920 May 20, 2022
3105f5d
Fix typo
andyduong1920 May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/nimble_template/addons/variants/phoenix/web/es_lint.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@ defmodule NimbleTemplate.Addons.Phoenix.Web.EsLint do
"""
"devDependencies": {
"eslint": "8.14.0",
"eslint-config-prettier": "8.5.0",
"eslint-plugin-prettier": "4.0.0",
"@nimblehq/eslint-config-nimble": "2.3.0",
"""
)

Expand Down
3 changes: 1 addition & 2 deletions lib/nimble_template/addons/variants/phoenix/web/style_lint.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ defmodule NimbleTemplate.Addons.Phoenix.Web.StyleLint do
"""
"devDependencies": {
"stylelint": "14.7.1",
"stylelint-config-property-sort-order-smacss": "9.0.0",
"stylelint-config-sass-guidelines": "9.0.1",
"@nimblehq/stylelint-config-nimble": "1.0.0",
"""
)

Expand Down
5 changes: 1 addition & 4 deletions priv/templates/nimble_template/assets/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,15 @@
"es2021": true
},
"extends": [
"eslint:recommended",
"prettier"
"@nimblehq/eslint-config-nimble"
],
"parserOptions": {
"ecmaVersion": 13,
"sourceType": "module"
},
"plugins": [
"prettier"
],
"rules": {
"prettier/prettier": "error",
"no-unused-vars": [
"error", {
"argsIgnorePattern": "^_"
Expand Down
7 changes: 2 additions & 5 deletions priv/templates/nimble_template/assets/.stylelintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"extends": [
"stylelint-config-sass-guidelines",
"stylelint-config-property-sort-order-smacss"
"@nimblehq/stylelint-config-nimble"
],
"ignoreFiles": [
"css/app.css",
Expand All @@ -10,8 +9,6 @@
"rules": {
"selector-class-pattern": null,
"no-eol-whitespace": true,
"max-nesting-depth": 3,
"scss/at-extend-no-missing-placeholder": null,
"order/properties-alphabetical-order": null
"scss/at-extend-no-missing-placeholder": null
}
}
3 changes: 1 addition & 2 deletions test/nimble_template/addons/variants/phoenix/web/es_lint_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ defmodule NimbleTemplate.Addons.Phoenix.Web.EsLintTest do
assert file =~ """
"devDependencies": {
"eslint": "8.14.0",
"eslint-config-prettier": "8.5.0",
"eslint-plugin-prettier": "4.0.0",
"@nimblehq/eslint-config-nimble": "2.3.0",
"""
end)
end)
Expand Down
3 changes: 1 addition & 2 deletions test/nimble_template/addons/variants/phoenix/web/style_lint_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ defmodule NimbleTemplate.Addons.Phoenix.Web.StyleLintTest do
assert file =~ """
"devDependencies": {
"stylelint": "14.7.1",
"stylelint-config-property-sort-order-smacss": "9.0.0",
"stylelint-config-sass-guidelines": "9.0.1",
"@nimblehq/stylelint-config-nimble": "1.0.0",
"""
end)
end)
Expand Down