Improved copyable in ReceiveModal #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was there an issue about this? Did designers say this should be changed? I personally don't like the new darker hover background. |
sisou
requested changes
Mar 7, 2022
Comment on lines
-150
to
-154
| &:hover, | ||
| &:focus, | ||
| &.copied { | ||
| background: rgba(5, 130, 202, 0.07); // Based on Nimiq Light Blue | ||
| } |
There was a problem hiding this comment.
These styles should be ported, to keep the same hover style.
Comment on lines
-133
to
-134
| border-radius: 0.625rem; | ||
| margin: 1rem 0 4rem; |
There was a problem hiding this comment.
This border-radius and margins should stay, to keep the same style.
|
@sisou the issue was about the text not turning blue on hover, the background should indeed stay in lightblue |
sisou
force-pushed
the
master
branch
2 times, most recently
from
b1c3ad0 to
40c00f4
Compare
mraveux
force-pushed
the
master
branch
2 times, most recently
from
920a067 to
9caffdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the
:hoverstate inReceiveModalBefore
After