Skip to content

TEST: simplify GIFTI warning check - #1529

Open
ananyavaidya7 wants to merge 2 commits into
nipy:masterfrom
ananyavaidya7:fix-simplify-warning-checks
Open

TEST: simplify GIFTI warning check#1529
ananyavaidya7 wants to merge 2 commits into
nipy:masterfrom
ananyavaidya7:fix-simplify-warning-checks

Conversation

@ananyavaidya7

Copy link
Copy Markdown

Summary

Simplifies the warning check in test_parse_dataarrays by replacing manual warning capture and length checking with pytest.warns(UserWarning).

This also removes the now-unused clear_and_catch_warnings import from the test module.

Closes #810.

Testing

  • python -m pytest nibabel/gifti/tests/test_parse_gifti_fast.py::test_parse_dataarrays -v
  • Result: 1 passed

@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.48%. Comparing base (4704d90) to head (8366ee8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1529      +/-   ##
==========================================
- Coverage   95.48%   95.48%   -0.01%     
==========================================
  Files         209      209              
  Lines       30050    30047       -3     
  Branches     4494     4494              
==========================================
- Hits        28692    28689       -3     
  Misses        926      926              
  Partials      432      432              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TEST: Simplify warning checks

1 participant