Skip to content

Conversation

@tclose
Copy link
Contributor

@tclose tclose commented Dec 8, 2025

Types of changes

  • New feature (non-breaking change which adds functionality)

Summary

Implements the Lmod environment to allow the use of environment modules used in NeuroDesk/Containers and typically used in HPC environments (e.g. module load fsl/6.0.7)

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 93.78531% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.31%. Comparing base (d7b5dc7) to head (e3781fe).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
pydra/environments/lmod.py 80.35% 6 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
+ Coverage   88.28%   88.31%   +0.03%     
==========================================
  Files          86       88       +2     
  Lines       18027    18198     +171     
  Branches     3517     3565      +48     
==========================================
+ Hits        15915    16072     +157     
- Misses       1734     1743       +9     
- Partials      378      383       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tclose tclose requested review from djarecka and effigies December 9, 2025 11:39
Copy link
Contributor

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Two notes.

@tclose
Copy link
Contributor Author

tclose commented Dec 12, 2025

@djarecka Hope it is ok, but I'm going to merge and release this feature as the NeuroDesk guys want to start testing it out

@tclose tclose merged commit 876be56 into main Dec 12, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants