-
-
Notifications
You must be signed in to change notification settings - Fork 98
Remove Java 11 from CI builds and apply all dependency upgrades from PR #1173 #1179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Comment |
|
@copilot remove jdk11 build setup and keep only jdk17 build setup. Don't remove |
…it to 6.0.0 Co-authored-by: anidotnet <[email protected]>
Done. Changes made in commit 36c4497: GitHub Actions (.github/workflows/build.yml)
Main POM (pom.xml)
Native Tests POM (nitrite-native-tests/pom.xml)
Build verified successfully with Java 17 and JUnit 6.0.0. |
pom.xml
Outdated
| <maven.compiler.release>11</maven.compiler.release> | ||
| <maven.compiler.source>11</maven.compiler.source> | ||
| <maven.compiler.target>11</maven.compiler.target> | ||
| <maven.compiler.release>17</maven.compiler.release> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot do not alter these version. All 3 maven.compiler.release, maven.compiler.source, maven.compiler.target versions must be 11 only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted in commit f24ad8b. The Maven compiler versions are now back to 11:
maven.compiler.release= 11maven.compiler.source= 11maven.compiler.target= 11
The CI builds will use JDK 17 but compile to Java 11 bytecode. The nitrite-native-tests module overrides to Java 17, allowing JUnit 6.0.0 to work.
Co-authored-by: anidotnet <[email protected]>
|
@copilot fix the build issues. |
Co-authored-by: anidotnet <[email protected]>
Fixed in commit bd123fb. Applied all 27 dependency upgrades from PR #1173: Main pom.xml - 25 dependency version upgrades including:
nitrite-native-tests/pom.xml - 2 upgrades:
Build verified successfully with JDK 17 compiling to Java 11 bytecode. |
|
@copilot rebuild fresh and resolve any build/test issues if found. |
Rebuilt from scratch and verified: ✅ Compilation: All modules compile successfully with JDK 17 targeting Java 11 bytecode Intermittent issue found:
All 27 dependency upgrades from PR #1173 are applied and working correctly. Build is stable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR resolves build failures from PR #1173 by upgrading JUnit to 6.0.0 (which requires Java 17 bytecode) while maintaining Java 11 bytecode compatibility for the main project. The solution removes Java 11 from CI builds and applies 27 dependency upgrades.
Key Changes:
- Removed Java 11 from CI build matrix; all builds now run on JDK 17
- Upgraded JUnit to 6.0.0 and native-maven-plugin to 0.11.2 in nitrite-native-tests module
- Applied 25 dependency version upgrades across the main pom.xml
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/build.yml |
Removes Java 11 from build matrix on all platforms and updates code coverage to run on Java 17 |
pom.xml |
Upgrades 25 dependencies including h2-mvstore, rocksdbjni, lombok, mockito, and various Maven plugins |
nitrite-native-tests/pom.xml |
Upgrades junit-bom to 6.0.0 and native-maven-plugin to 0.11.2 for native image testing |
Updated pom.xml to use RocksDB version 10.2.1 and configured Dependabot to pin org.rocksdb:rocksdbjni to this version for all update types.
PR #1173 upgrades JUnit to 6.0.0, which requires Java 17 bytecode. This PR removes Java 11 from CI builds and applies all 27 dependency upgrades from PR #1173 while maintaining Java 11 bytecode compatibility for the main project.
Changes
GitHub Actions Workflow
Maven Configuration
maven.compiler.release,maven.compiler.source, andmaven.compiler.targetat version 11Dependencies (27 upgrades from PR #1173)
Main pom.xml - 25 dependency version upgrades:
nitrite-native-tests/pom.xml - 2 upgrades:
How This Works
Testing
Fixes #1178
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.