Skip to content

Conversation

@pyrotelekinetic
Copy link
Contributor

@pyrotelekinetic pyrotelekinetic commented Jan 30, 2024

nixos-version was missing the --configuration-revision and --json options. I'm not a zsh user; I have not tested this. I thought it made sense to update this here while I was already doing the same on nix-bash-completions#27

pyrotelekinetic and others added 2 commits January 29, 2024 17:27
Namely, '--configuration-revision' and '--json' were missing.
@SebTM
Copy link
Contributor

SebTM commented Mar 7, 2024

Thanks for your submission/bringing this issue up, sadly it was not working as expected so I did my best to fix it - completion looks now like this:
Screenshot from 2024-03-07 13-49-08

I would appreciate one review/tester before I go ahead and merge ✌🏻

@SebTM
Copy link
Contributor

SebTM commented Mar 7, 2024

// cc @theesm (can't add you as reviewer) @Mic92

@Mic92
Copy link
Member

Mic92 commented Mar 7, 2024

// cc @theesm (can't add you as reviewer) @Mic92

What do you want me to do? A review?

@SebTM
Copy link
Contributor

SebTM commented Mar 7, 2024

If you like to, but mainly I was marking you also because of the issue with @theesm as he wanted to join as well/had contact with you in #44 (no permissions to check team myself I guess, can't see a matching category in settings)

@SebTM SebTM merged commit 6e782b9 into nix-community:master Mar 14, 2024
@pyrotelekinetic pyrotelekinetic deleted the update-nixos-version branch June 24, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants