Skip to content

A few more tests for the interaction between sealed and #513 - #515

Merged
kelloggm merged 10 commits into
mainfrom
issue509
Aug 20, 2026
Merged

A few more tests for the interaction between sealed and #513#515
kelloggm merged 10 commits into
mainfrom
issue509

Conversation

@kelloggm

Copy link
Copy Markdown
Collaborator

These were uncommitted in my local repo and should have been added with the changes in response to code rabbit's review before I merged #513.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: eda63738-9fd9-4584-adba-9084e61bb1de

📥 Commits

Reviewing files that changed from the base of the PR and between e1317d5 and 7636134.

📒 Files selected for processing (26)
  • src/test/java/org/checkerframework/specimin/NonExtendableCastOperandSealedTest.java
  • src/test/java/org/checkerframework/specimin/NonExtendableTargetSealedTest.java
  • src/test/java/org/checkerframework/specimin/SealedPermitsGeneratedSubtypeTest.java
  • src/test/resources/nonextendablecastoperandsealed/expected/com/example/Known.java
  • src/test/resources/nonextendablecastoperandsealed/expected/com/example/SealedBase.java
  • src/test/resources/nonextendablecastoperandsealed/expected/com/example/Simple.java
  • src/test/resources/nonextendablecastoperandsealed/expected/org/example/Baz.java
  • src/test/resources/nonextendablecastoperandsealed/expected/org/example/Foo.java
  • src/test/resources/nonextendablecastoperandsealed/input/com/example/Known.java
  • src/test/resources/nonextendablecastoperandsealed/input/com/example/SealedBase.java
  • src/test/resources/nonextendablecastoperandsealed/input/com/example/Simple.java
  • src/test/resources/nonextendabletargetsealed/expected/com/example/Known.java
  • src/test/resources/nonextendabletargetsealed/expected/com/example/SealedBase.java
  • src/test/resources/nonextendabletargetsealed/expected/com/example/Simple.java
  • src/test/resources/nonextendabletargetsealed/expected/org/example/Baz.java
  • src/test/resources/nonextendabletargetsealed/expected/org/example/Foo.java
  • src/test/resources/nonextendabletargetsealed/expected/org/example/GetReturnType.java
  • src/test/resources/nonextendabletargetsealed/input/com/example/Known.java
  • src/test/resources/nonextendabletargetsealed/input/com/example/SealedBase.java
  • src/test/resources/nonextendabletargetsealed/input/com/example/Simple.java
  • src/test/resources/sealedpermitsgeneratedsubtype/expected/com/example/Baz.java
  • src/test/resources/sealedpermitsgeneratedsubtype/expected/com/example/SealedBase.java
  • src/test/resources/sealedpermitsgeneratedsubtype/expected/com/example/Simple.java
  • src/test/resources/sealedpermitsgeneratedsubtype/expected/org/example/Foo.java
  • src/test/resources/sealedpermitsgeneratedsubtype/input/com/example/SealedBase.java
  • src/test/resources/sealedpermitsgeneratedsubtype/input/com/example/Simple.java

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Added three JUnit integration tests for sealed cast operands, sealed assignment targets, and generated permitted subtypes. Added input and expected-output fixtures covering SealedBase, Known, Baz, Foo, and Simple.

Possibly related PRs

Suggested reviewers: theron-wang

Merge Risk: ⚪ Minimal · up to 76361

This change adds regression tests and expected fixtures without changing production behavior; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue509

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kelloggm
kelloggm merged commit 7a2a935 into main Aug 20, 2026
3 checks passed
@kelloggm
kelloggm deleted the issue509 branch August 20, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant