Skip to content

Conversation

@nmaarnio
Copy link
Collaborator

@nmaarnio nmaarnio commented Oct 31, 2025

Description

Generalize fences algorithm was refactored into GeneralizeFences algorithm class that inherits BaseAlgorithm.

Changes in this PR:

  • Refactor generalize fences
    • Formulate algorithm into GeneralizeFences algorithm class that inherits BaseAlgorithm
    • Add input geometry type checks
  • Add CLI command for GeneralizeFences
  • Increase test coverage
  • Define default parameter values

ID handling will be implemented in a separate PR.

Type of change

  • Bug fix

  • New feature

  • Other

  • Non-breaking change

  • Breaking change

Developer checklist

  • A CHANGELOG entry has been included (only when change is visible to users)

@nmaarnio nmaarnio marked this pull request as ready for review November 3, 2025 07:38
@nmaarnio nmaarnio requested a review from JuhoErvasti November 3, 2025 09:48
Added a CLI parameter type called GeoPackageOptionMandatory for
cases when reference data must be passed to an algorithm.
@nmaarnio nmaarnio force-pushed the refactor-generalize-fences branch from a6af5eb to 245041a Compare November 4, 2025 07:06
@nmaarnio nmaarnio force-pushed the refactor-generalize-fences branch from 8ebaaa8 to 4a65c73 Compare November 4, 2025 12:35
Copy link
Collaborator

@JuhoErvasti JuhoErvasti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Are the Z values considered in this? The test data doesn't seem to have them. But I think those can be handled in a separate PR, so I'm okay to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants