Merged
Conversation
Owner
|
Great. Thank you. The upgrade to h3 v4 can be done later. The python downgrade is a good solution for now |
Collaborator
Author
|
just to mention, this already does the upgrade to |
Collaborator
Author
|
I noticed that some polars UDF don't get tested, so before releasing these changes it might be good to add simple tests for these |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems we have two options:
h3>=4.0For now, this will downgrade python
Edit after the merge: I decided to look into migrating docs and tests to
h3>=4, so this also closes #82