Skip to content

Incorrect auth server is used for credential offers #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnotheis merged 4 commits into from
Feb 25, 2026
Merged

Incorrect auth server is used for credential offers #974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df0ffb3
chore: add application error
tnotheis Feb 25, 2026
5ed6dcd
fix: use auth server from credential offer instead of from issuer met…
tnotheis Feb 25, 2026
37938ff
refactor: remove incorrect null suppression
tnotheis Feb 25, 2026
7af4d37
fix: return in case of missing authorization server
tnotheis Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/app-runtime/src/AppRuntimeErrors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ class AppStringProcessor {
return new ApplicationError("error.appruntime.appStringProcessor.passwordNotProvided", "No password was provided.");
}

public invalidCredentialOffer(): ApplicationError {
return new ApplicationError("error.appruntime.appStringProcessor.invalidCredentialOffer", "The scanned code contains an invalid credential offer.");
}

public externalOauthRegistrationNotProvided(): ApplicationError {
return new ApplicationError("error.appruntime.appStringProcessor.externalOauthRegistrationNotProvided", "No external OAuth registration was provided.");
}
Expand Down
10 changes: 8 additions & 2 deletions packages/app-runtime/src/AppStringProcessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,14 @@ export class AppStringProcessor {
return Result.ok(undefined);
}

// TODO: Multiple authorization servers not supported yet
const tokenResult = await uiBridge.performOauthAuthentication(credentialOffer.metadata.authorizationServers[0].issuer);
const authorizationServer = credentialOffer.credentialOfferPayload.grants!.authorization_code!.authorization_server;
if (!authorizationServer) {
await uiBridge.showError(AppRuntimeErrors.appStringProcessor.invalidCredentialOffer());
this.logger.error("Credential offer does not contain an authorization server", credentialOffer);
return Result.ok(undefined);
}

const tokenResult = await uiBridge.performOauthAuthentication(authorizationServer);
if (tokenResult.isError) {
this.logger.error("Could not perform OAuth authentication", tokenResult.error);
return Result.ok(undefined);
Expand Down