Move Runtime Events to runtime-types package#985
Merged
Milena-Czierlinski merged 10 commits intomainfrom Mar 6, 2026
Merged
Conversation
tnotheis
requested changes
Mar 6, 2026
Member
tnotheis
left a comment
tnotheis
left a comment
There was a problem hiding this comment.
Regarding the file structure of the runtime-types: wouldn't it make more sense to group by component on top level and then by type (event/dto) instead of vice versa?
Here's what I'm thinking of:
runtimes-types
consumption
dtos
events
runtime
dtos
events
```
Member
Author
|
Regarding the file structure, I find it more intuitive this way. :) |
tnotheis
previously approved these changes
Mar 6, 2026
tnotheis
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Description
This way it isn't necessary to import the whole runtime when only needing the definitions of the runtime events. The connector sdk e.g. already imports the runtime-types, so if it is used, no additional import of the runtime is necessary.