Skip to content

fix: add catch for get conn exception #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: add catch for get conn exception #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
acea9f9
fix: add catch for get conn exception
killagu Oct 23, 2025
93e75cb
fix: add catch for get conn exception
killagu Oct 23, 2025
b81393f
Merge branch 'master' into pick/fix/handle_reject
killagu Oct 23, 2025
c17dbe0
f
killagu Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
},
"dependencies": {
"mysql2": "^3.9.1",
"sqlstring": "^2.3.3"
"sqlstring": "^2.3.3",
"onelogger": "^1.0.0"
},
"devDependencies": {
"@eggjs/tsconfig": "^1.3.2",
Expand Down
5 changes: 5 additions & 0 deletions src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { promisify } from 'node:util';
import { setTimeout } from 'node:timers/promises';
import mysql, { Pool } from 'mysql2';
import type { PoolOptions } from 'mysql2';
import { getLogger } from 'onelogger';
import type { PoolConnectionPromisify, RDSClientOptions, TransactionContext, TransactionScope } from './types';
import { Operator } from './operator';
import { RDSConnection } from './connection';
Expand Down Expand Up @@ -167,6 +168,10 @@ export class RDSClient extends Operator {
if (typeof connOrTimeout === 'number') {
connPromise.then(conn => {
conn.release();
}).catch(e => {
const logger = getLogger();
e.message = 'get conn failed after timeout: ' + e.message;
logger.warn(e);
Comment on lines +173 to +174
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Mutating the original error object by modifying its message property is generally considered an anti-pattern. It can obscure the original error source and make debugging more difficult. A better approach is to log the additional context along with the original error, without changing it. This makes logs clearer and preserves the original error information for easier debugging.

Suggested change
e.message = 'get conn failed after timeout: ' + e.message;
logger.warn(e);
logger.warn(`get conn failed after timeout. Original error: ${e.message}`, e);

});
throw new PoolWaitTimeoutError(`get connection timeout after ${connOrTimeout}ms`);
}
Expand Down