Skip to content

Conversation

@NitnerocL
Copy link

@NitnerocL NitnerocL commented Dec 4, 2025

I intend to reuse code from Dialogs to display floating panels (see #3). For this, I need the panel / dialog to be resizable in only one direction (away from the sticky side).

I refactored ResizableContainer to allow customizing the resize direction, but didn't change the current behavior and API of Dialog.

@NitnerocL

This comment was marked as outdated.

@NitnerocL NitnerocL marked this pull request as draft December 7, 2025 17:21
@NitnerocL
Copy link
Author

After further thoughts, I think a better approach would be to create a new abstract class FloatingPanel, inherited by both Dialog and the new DockingPanel class. That would be more coherent than having DockingPanel extending Dialog, and that would avoid mutating Dialog and introducing breaking changes.

I will submit an update to remove breaking changes.

@NitnerocL NitnerocL force-pushed the feature/specify-allowed-resize-direction-for-dialogs branch from e66e368 to c89012b Compare December 9, 2025 11:04
@NitnerocL NitnerocL marked this pull request as ready for review December 9, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant