feat: create metadata entries generator #272
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocking this until #275 is merged. |
avivkeller
reviewed
May 16, 2025
bin/commands/generate.mjs
Outdated
Comment on lines
133
to
149
| const releases = await getAllMajors(); | ||
|
|
||
| await Promise.all( | ||
| docs.map(async doc => { | ||
| const { runGenerators } = createGenerator(doc); | ||
|
|
||
| await runGenerators({ | ||
| generators: opts.target, | ||
| input: opts.input, | ||
| output: opts.output && resolve(opts.output), | ||
| version: coerce(opts.version), | ||
| releases, | ||
| gitRef: opts.gitRef, | ||
| threads: parseInt(opts.threads, 10), | ||
| }); | ||
| }) | ||
| ); |
There was a problem hiding this comment.
I know this PR is still a draft, but I'm concerned that this will overload the system's CPU. We already run each generator on it's own thread, why do we need to iterate on each doc as well?
There was a problem hiding this comment.
@avivkeller It was a misunderstanding, fixed now. Can you take a look?
araujogui
commented
May 23, 2025
| console.error('Lint failed; aborting generation.'); | ||
| process.exit(1); | ||
| } | ||
| // if (!opts.skipLint && !runLint(docs)) { |
There was a problem hiding this comment.
I'll fix this after #275 is merged, because we need the raw asts here.
araujogui
force-pushed
the
refactor-parsers
branch
from
f6ba0c8 to
37a572d
Compare
|
@araujogui I saw there is a blocked label, could you elaborate what's blocked? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates metadata entries generator
Related Issues
Fixes #271
Check List
node --run testand all tests passed.node --run format&node --run lint.