use ArrayBuffer->Data() when available #1002
Open
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flarna
reviewed
Sep 13, 2025
This is faster than accessing the BackingStore. API is available in V8 10.5+ per nodejs/node#32226 (comment). It was backported to Node.js v18.8.0 in nodejs/node@a0c5783, but Node.js minor versions can't be used as the basis for feature support.
zbjornson
force-pushed
the
zb/buffer-data
branch
from
905e787 to
539ada6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is faster than accessing the BackingStore. API is available in V8 10.5+ per nodejs/node#32226 (comment).
Manually tested in Node.js v18.20 and v20.