Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add convert result for StreamPipe::New #57613

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: add convert result for StreamPipe::New #57613

wants to merge 1 commit into from

Conversation

wooffie
Copy link
Contributor

@wooffie wooffie commented Mar 25, 2025

Fixes: #57612

Do it like here:

node/src/stream_base.cc

Line 628 in b4280ef

StreamBase* wrap = StreamBase::FromObject(args.This().As<Object>());

node/src/node_http_parser.cc

Line 717 in b4280ef

StreamBase* stream = StreamBase::FromObject(args[0].As<Object>());

node/src/crypto/crypto_tls.cc

Line 545 in b4280ef

StreamBase* stream = StreamBase::FromObject(args[0].As<Object>());

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 25, 2025
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 25, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.22%. Comparing base (ada4abf) to head (f4fa10b).

Files with missing lines Patch % Lines
src/stream_pipe.cc 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #57613   +/-   ##
=======================================
  Coverage   90.21%   90.22%           
=======================================
  Files         630      630           
  Lines      185518   185520    +2     
  Branches    36383    36387    +4     
=======================================
+ Hits       167360   167380   +20     
- Misses      11033    11037    +4     
+ Partials     7125     7103   -22
Files with missing lines Coverage Δ
src/stream_pipe.cc 59.53% <0.00%> (-0.56%) ⬇️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65934/

@wooffie
Copy link
Contributor Author

wooffie commented Apr 7, 2025

Rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add checks for stream_pipe.cc
3 participants
@wooffie @nodejs-github-bot @lpinca