Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: add convert result for StreamPipe::New #57613

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wooffie
Copy link
Contributor

@wooffie wooffie commented Mar 25, 2025

Fixes: #57612

Do it like here:

StreamBase* wrap = StreamBase::FromObject(args.This().As<Object>());

StreamBase* stream = StreamBase::FromObject(args[0].As<Object>());

StreamBase* stream = StreamBase::FromObject(args[0].As<Object>());

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 25, 2025
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 25, 2025
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.22%. Comparing base (1123585) to head (db9d6a1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/stream_pipe.cc 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #57613      +/-   ##
==========================================
- Coverage   90.22%   90.22%   -0.01%     
==========================================
  Files         630      630              
  Lines      185055   185057       +2     
  Branches    36216    36218       +2     
==========================================
- Hits       166975   166960      -15     
- Misses      11042    11048       +6     
- Partials     7038     7049      +11     
Files with missing lines Coverage Δ
src/stream_pipe.cc 59.53% <0.00%> (-0.56%) ⬇️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add checks for stream_pipe.cc
3 participants