Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checks for stream_pipe.cc #57612

Open
wooffie opened this issue Mar 25, 2025 · 0 comments · May be fixed by #57613
Open

Add checks for stream_pipe.cc #57612

wooffie opened this issue Mar 25, 2025 · 0 comments · May be fixed by #57613

Comments

@wooffie
Copy link
Contributor

wooffie commented Mar 25, 2025

I think we should add check for nullptr here:

node/src/stream_pipe.cc

Line 280 in b4280ef

StreamBase* sink = StreamBase::FromObject(args[1].As<Object>());

We checked that args is Object, but not checked for type after converting

I'll prepare PR

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Reporter: Burkov Egor (eburkov@rvision.ru).

Organization: R-Vision (support@rvision.ru).
wooffie added a commit to wooffie/node that referenced this issue Mar 25, 2025
@wooffie
src: add convert result for StreamPipe::New
db9d6a1 
Fixes: nodejs#57612
@wooffie wooffie linked a pull request Mar 25, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: add convert result for StreamPipe::New wooffie/node
1 participant
@wooffie