-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module: improve getPackageType
performance
#57599
base: main
Are you sure you want to change the base?
module: improve getPackageType
performance
#57599
Conversation
Review requested:
|
759229d
to
2c75280
Compare
I'll review tomorrow morning. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57599 +/- ##
==========================================
- Coverage 90.22% 90.22% -0.01%
==========================================
Files 630 630
Lines 185055 185064 +9
Branches 36216 36223 +7
==========================================
- Hits 166975 166969 -6
- Misses 11042 11043 +1
- Partials 7038 7052 +14
🚀 New features to boost your workflow:
|
2052d4a
to
3406431
Compare
3406431
to
0670e6e
Compare
0670e6e
to
46649e7
Compare
Co-authored-by: James M Snell <[email protected]>
I think this should be ready to go but we're unable to run jenkins CI on it currently due to some ongoing maintenance, Once the CI system is unrestricted again we'll get the CI run scheduled so we can get this landed. |
packageJsonReader#getPackageType
currently gets the whole package scope config from the C++ binding and then extracts itstype
field, my understanding is that this is wasteful (since the whole object needs to be serialized to cross the C++/JS boundary) and that gathering the type in C++ and returning only that would be more efficient, that's what I'm attempting to do in this PR 🙂 (I hope my C++ makes sense as I am pretty inexperienced with it 🤞)