Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add "Do I still need this dependency for my Node.js app?" to ambassadors program #57600

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

bmuenzenmeyer
Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer commented Mar 23, 2025

Also included is:

  • a632929 - fixing some typos in previous content
  • 20c83cf - normalizing the markdown headers. without this, the levels bled into one another incorrectly (⬇️ now fixed)
    image

I chose to include all this together for review clarity and noise, but open to feedback of any kind. Cheers!
Understand most of this won't be acted upon until after collab summit, but I wanted to follow through here.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 23, 2025

##### Goal

Advancements over time in Node.js are improving the out of the box experience. New versions are released all the time across Active LTS and Current development lines. It's easy to miss something between the release notes and our busy work schedules.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Advancements over time in Node.js are improving the out of the box experience. New versions are released all the time across Active LTS and Current development lines. It's easy to miss something between the release notes and our busy work schedules.
Advancements over time in Node.js are improving the out of the box experience. New versions are released regularly across Active LTS and Current development lines. It's easy to miss something between the release notes and our busy work schedules.

nitpic

@bmuenzenmeyer
Copy link
Contributor Author

bmuenzenmeyer commented Mar 23, 2025

make does not work on my Windows machine, so trying to approximate it with node tools/lint-md/lint-md.mjs --format .\doc\contributing\advocacy-ambassador-program.md 🤞

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

| [parsing arguments](https://nodejs.org/api/util.html#utilparseargsconfig) | [18.3.0](https://nodejs.org/en/blog/release/v18.3.0) | Stable as of 20.0.0 |
| [reading environment](https://nodejs.org/api/cli.html#--env-fileconfig) | [20.6.0](https://nodejs.org/en/blog/release/v20.6.0) | Active Development |
| [styling output](https://nodejs.org/docs/latest-v22.x/api/util.html#utilstyletextformat-text-options) | [20.12.0](https://nodejs.org/en/blog/release/v20.12.0) | Stable, as of [22.13.0](https://github.com/nodejs/node/pull/56329) |
| [run TypeScript](https://nodejs.org/api/cli.html#--experimental-strip-types) | [22.6.0](https://nodejs.org/en/blog/release/v22.6.0) | Active Development |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Npm run vs. Node --run can be added as well

@bmuenzenmeyer bmuenzenmeyer changed the title doc: add "do i still need this node.js dependency?" to ambassadors program doc: add "Do I still need this dependency for my Node.js app?" to ambassadors program Mar 24, 2025
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants