assert,util: handle invalid dates as equal in deep comparison

[BridgeAR]

Invalid dates are now handled as equal in all deep comparisons.

This is more of a usability improvement than a breaking change, since all invalid dates have always thrown errors when being compared until now.

[nodejs-github-bot]

Review requested:

• @nodejs/performance

[BridgeAR]

I am not sure if we want to add the entries to our benchmarks yet, since this would just always fail when comparing it with older versions.

[H4ad]

The other option is to wait a release to include, but I don't thing is worthy, so I would keep it

[ljharb]

what would have thrown before when comparing two invalid dates? it seems like comparing two invalid dates would have compared as false before, and now will compare as true, which does seem breaking.

[BridgeAR]

@ljharb

> assert.deepStrictEqual(new Date('foo'), new Date('foo'))
Uncaught:
AssertionError [ERR_ASSERTION]: Values have same structure but are not reference-equal:

Invalid Date

    at REPL11:1:8  {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: Invalid Date,
  expected: Invalid Date,
  operator: 'deepStrictEqual'
}

[ljharb]

ohhh right, because it's an assert api, not a predicate. fair enough :-)

[H4ad]

The other option is to wait a release to include, but I don't thing is worthy, so I would keep it

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (a4f556f) to head (ca78dda).
Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57627      +/-   ##
==========================================
- Coverage   90.24%   90.22%   -0.02%     
==========================================
  Files         630      630              
  Lines      185129   185060      -69     
  Branches    36238    36223      -15     
==========================================
- Hits       167064   166967      -97     
- Misses      11045    11046       +1     
- Partials     7020     7047      +27     

Files with missing lines	Coverage Δ
lib/internal/util/comparisons.js	99.63% <100.00%> (+<0.01%)	⬆️

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.