Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add new companion status to governance document #57628

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BridgeAR
Copy link
Member

In the recent Node.js discussions around nominations, we also discussed the need to show that someone contributed to the project in a significant way before we are able to nominate someone to become a collaborator.

This governance change should address that need.

The documentation is intentionally kept brief for now. AFAIC we are able to extend this at a later point.

@BridgeAR BridgeAR requested review from Trott, JakobJingleheimer and a team March 25, 2025 22:48
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Mar 25, 2025
@BridgeAR BridgeAR requested a review from a team March 25, 2025 22:48
@ljharb
Copy link
Member

ljharb commented Mar 25, 2025

Is there a previous discussion about the naming, or is this the proper place to discuss it?

@BridgeAR
Copy link
Member Author

@ljharb there was no discussion around the name so far. Just about the need for the status as such.

I suggested the name because it felt to me that it reflects that someone acted well towards the project. I am open to suggestions.

@ljharb
Copy link
Member

ljharb commented Mar 25, 2025

I'm not stoked about the term "companion" - it connotes to me someone who's more along for the ride, rather than someone who's meaningfully contributed in non-code ways to the project.

(I'll try to come up with some alternative suggestions, but i don't have any off the top of my head)

@BethGriggs
Copy link
Member

Quoting myself from nodejs/TSC#1702 (comment) 😓

(I also don't think we should create a separate group called 'companion' or something for people doing wider project work - the optics of that are that they're in a lesser role in some way. Non-core code work can be just as critical for the project.)

This alludes to a hierarchical status (being a companion before a collaborator) which still seems to reinforce that non-core work isn't as valued.

@BridgeAR
Copy link
Member Author

@BethGriggs I am somewhat confused by that concern. The status should a) also apply to core contributors and b) make it easier to reach the status that someone gets something back from the project. Right now, someone would have to wait longer to be nominated / do more. This allows to have a intermediate step and that seems to increase the visibility for someone.

@jasnell
Copy link
Member

jasnell commented Mar 26, 2025

I'm generally -1 on adding a new status label at all, regardless of what it is called. I don't believe there's any actual value in doing so.

@marco-ippolito
Copy link
Member

I'm -1 I think collaborator role is enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants