Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update collationruleparser.h #57629

Closed
wants to merge 1 commit into from
Closed

Update collationruleparser.h #57629

wants to merge 1 commit into from
+58 −32

Conversation

AgustinWojtyszyn
Copy link

Refactor and improve the CollationRuleParser code:

  • Renamed constants for better clarity.
  • Used constexpr for constant expressions to improve performance.
  • Added detailed comments and documentation for better understanding.
  • Split complex functions into smaller, more manageable pieces.
  • Removed unused variables and cleaned up the code.

@AgustinWojtyszyn
Update collationruleparser.h
fe90d9d 
Refactor and improve the CollationRuleParser code:
- Renamed constants for better clarity.
- Used `constexpr` for constant expressions to improve performance.
- Added detailed comments and documentation for better understanding.
- Split complex functions into smaller, more manageable pieces.
- Removed unused variables and cleaned up the code.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Mar 25, 2025
RaisinTen
RaisinTen requested changes Mar 26, 2025
View reviewed changes
Copy link
Member

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR but this is a code change in a vendored dependency which is supposed to be submitted upstream, so consider sending it to https://github.com/unicode-org/icu

@RaisinTen RaisinTen closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen requested changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AgustinWojtyszyn @nodejs-github-bot @RaisinTen