fs: glob is stable, so should not emit experimental warnings #58236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
|
cc @jasnell |
cjihrig
approved these changes
May 8, 2025
marco-ippolito
approved these changes
May 8, 2025
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58236 +/- ##
==========================================
- Coverage 90.14% 90.12% -0.02%
==========================================
Files 629 629
Lines 186634 186626 -8
Branches 36616 36624 +8
==========================================
- Hits 168236 168203 -33
- Misses 11204 11217 +13
- Partials 7194 7206 +12
🚀 New features to boost your workflow:
|
lpinca
approved these changes
May 9, 2025
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6710c00 |
targos
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #58236 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 19, 2025
PR-URL: #58236 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced May 19, 2025
aduh95
pushed a commit
that referenced
this pull request
May 21, 2025
PR-URL: #58236 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #57513
fs.globwas marked as stable, but that was only in the documentation, so if it's considered stable, it should not emit experimental warnings.