Skip to content

src: remove unused shouldRetryAsESM internal binding #58265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

src: remove unused shouldRetryAsESM internal binding #58265

merged 1 commit into from
May 12, 2025
+0 −17

Conversation

dario-piotrowicz
Copy link
Member

This PR is removing the shouldRetryAsESM internal binding, which I believe is no longer used.

I believe that the binding stopped being used in #52047.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels May 10, 2025
@codecov Codecov
Copy link

codecov bot commented May 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.17%. Comparing base (578a893) to head (dccc227).
Report is 19 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58265      +/-   ##
==========================================
- Coverage   90.18%   90.17%   -0.01%     
==========================================
  Files         629      629              
  Lines      186639   186617      -22     
  Branches    36654    36655       +1     
==========================================
- Hits       168313   168275      -38     
+ Misses      11134    11114      -20     
- Partials     7192     7228      +36
Files with missing lines Coverage Δ
src/node_contextify.cc 81.20% <ø> (+0.70%) ⬆️

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dario-piotrowicz dario-piotrowicz added the request-ci Add this label to start a Jenkins CI on a PR. label May 10, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 10, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66745/

aduh95
aduh95 approved these changes May 10, 2025
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI agrees

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 10, 2025
mertcanaltin
mertcanaltin approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@mertcanaltin mertcanaltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2025
@nodejs-github-bot nodejs-github-bot merged commit 200abfc into nodejs:main May 12, 2025
77 of 78 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 200abfc

@dario-piotrowicz dario-piotrowicz deleted the dario/remove-shouldRetryAsESM-unused-internal-binding branch May 12, 2025 21:49
targos pushed a commit that referenced this pull request May 16, 2025
@dario-piotrowicz @targos
src: remove unused shouldRetryAsESM internal binding
4db5d0b 
PR-URL: #58265
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@aduh95 aduh95 aduh95 approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@mertcanaltin mertcanaltin mertcanaltin approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@dario-piotrowicz @nodejs-github-bot @jasnell @lpinca @anonrig @UlisesGascon @aduh95 @marco-ippolito @mertcanaltin @RaisinTen