util: fix stylize of special properties in inspect #60479
Merged
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, formatExtraProperties applied ctx.stylize to the entire '[key]: value' string. This caused the colon and space to be styled, making the output inconsistent with normal object properties. Now, only the key itself is stylized, and the colon and space remain unstyled, aligning with the formatting of regular properties. Refs: nodejs#60131
nodejs-github-bot
added
needs-ci
cjihrig
approved these changes
Oct 29, 2025
BridgeAR
approved these changes
Oct 29, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60479 +/- ##
==========================================
+ Coverage 88.56% 88.58% +0.01%
==========================================
Files 704 704
Lines 207826 207827 +1
Branches 40035 40037 +2
==========================================
+ Hits 184059 184100 +41
+ Misses 15802 15759 -43
- Partials 7965 7968 +3
🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
request-ci
ljharb
approved these changes
Oct 30, 2025
lpinca
approved these changes
Oct 30, 2025
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in fbef1cf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, formatExtraProperties applied ctx.stylize to the entire '[key]: value' string. This caused the colon and space to be styled, making the output inconsistent with normal object properties.
Now, only the key itself is stylized, and the colon and space remain unstyled, aligning with the formatting of regular properties.
Refs: #60131