src: fix missing file error when --watch used without argument#62334
Open
nickshiro wants to merge 1 commit intonodejs:mainfrom
Open
src: fix missing file error when --watch used without argument#62334nickshiro wants to merge 1 commit intonodejs:mainfrom
nickshiro wants to merge 1 commit intonodejs:mainfrom
Conversation
Member
|
The --watch argument checks are here: Lines 258 to 271 in 56aba88 The last of these is what needs fixing. |
Author
|
Both
--watch is consumed by the parser before What's the intended approach to distinguish these two cases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Previously, running
node --watchwithout specifying a file wouldstart the REPL instead of exiting with code 9. This was a regression
found in issue #62305.
Solution
process.argv[1]immediately aftermarkBootstrapComplete(). If no file is provided, print theoriginal error message and exit with code
9.test/parallel/test-watch-mode-without-file.mjsfor check error message and exit with correct code.