Make site work with the Cloudflare OpenNext adapter #7383
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dario-piotrowicz
force-pushed
the
dario/opennextjs-cloudflare
branch
from
b5e1217 to
0463451
Compare
|
@dario-piotrowicz do we have updates here? 👀 |
|
Hey @ovflowd 👋 Sorry for keeping the PR lingering, there are a few smaller issues we addressed in our adapter (that I need to reflect here), and also ISR should be coming soon (@vicb can provide more context) Besides that I just need to rebase the PR, the only significant issue remaining should be filesystem access, but I wanted to clarify that with you, I'll drop you a message today to clarify things (PS: I hope the PR is not bothering you 🙇, if you want I can close it and reopen it when we're ready?) |
This is awesome news. Excited to hear from @vicb
I believe we sorted that out on Slack 🖖
Not at all <3 |
dario-piotrowicz
force-pushed
the
dario/opennextjs-cloudflare
branch
2 times, most recently
from
542f172 to
2723110
Compare
dario-piotrowicz
force-pushed
the
dario/opennextjs-cloudflare
branch
from
2723110 to
3481f56
Compare
dario-piotrowicz
force-pushed
the
dario/opennextjs-cloudflare
branch
from
3481f56 to
f746d5c
Compare
dario-piotrowicz
force-pushed
the
dario/opennextjs-cloudflare
branch
from
f746d5c to
4ff9d79
Compare
dario-piotrowicz
force-pushed
the
dario/opennextjs-cloudflare
branch
from
4ff9d79 to
fac63da
Compare
|
Deployment failed with the following error: |
remove all changes related to async context
dario-piotrowicz
force-pushed
the
dario/opennextjs-cloudflare
branch
from
3b1fc58 to
aebf63f
Compare
dario-piotrowicz
force-pushed
the
dario/opennextjs-cloudflare
branch
from
a7a5218 to
a1f4000
Compare
dario-piotrowicz
force-pushed
the
dario/opennextjs-cloudflare
branch
from
a1f4000 to
2fb80a8
Compare
apps/site/package.json
Outdated
| "test:unit": "cross-env NODE_NO_WARNINGS=1 jest", | ||
| "test:unit:watch": "npm run test:unit -- --watch", | ||
| "test": "turbo test:unit", | ||
| "build:worker": "npx opennextjs-cloudflare build", | ||
| "postbuild:worker": "node ./.cloudflare/prepare-build.mjs", | ||
| "cf:preview": "npm run build:worker && sleep 3 && npx wrangler dev", | ||
| "cf:deploy": "npx wrangler deploy" | ||
| "cf:deploy": "npx wrangler deploy", | ||
| "postinstall": "npm run build-blog-data" |
There was a problem hiding this comment.
I'd discourage using postinstall scripts :)
There was a problem hiding this comment.
the problem is that I could not find a way to commit an initial version of the public/blog-data.json file and then have it included in the repository but not track any more changes made to it
I did a bunch of googling and I am not sure if that's actually possible 😕 (see: https://stackoverflow.com/questions/3319479/can-i-git-commit-a-file-and-ignore-its-content-changes, https://git-scm.com/docs/gitfaq#ignore-tracked-files)
So with this script as soon as install is run the file is created and everything works as intended, if you want I can remove it and things would mostly still work just fine, the only problem being that the apps/site/next.json.mjs file would have a type error until.... oh it's a mjs file and it's not type checked...
so are you happy with me just removing the postinstall script? and/or do you have a suggestion on how to set up an initial blog-data.json?
There was a problem hiding this comment.
the problem is that I could not find a way to commit an initial version of the public/blog-data.json file and then have it included in the repository but not track any more changes made to it
We don't need that.
then have it included in the repository but not track any more changes made to it
You can do that, you commit a file initially, then add it ton gitignore, and then any update onwards is ignored.
There was a problem hiding this comment.
So with this script as soon as install is run the file is created and everything works as intended, if you want I can remove it and things would mostly still work just fine, the only problem being that the apps/site/next.json.mjs file would have a type error until.... oh it's a mjs file and it's not type checked...
I get that, an initial empty file is fine; no need of a postinstall.
There was a problem hiding this comment.
You can do that, you commit a file initially, then add it ton gitignore, and then any update onwards is ignored.
I don't think you can, a file is either tracked by git or not, it can't be tracked to a certain point and then kept but not tracked, at least that's my understanding of how git works
see:
avoid temporary blogData variable
remove postinstall script
add sleep to make sure public/blog-data.json file is created
remove unnecessary chokidar
|
After a bunch of poking around (and help from @penalosa 🫶) I've narrowed down that the issue regarding the initial flashing is due to opennextjs/opennextjs-cloudflare#511 , the problem is that an undefined |
This PR applies changes to make it so that the site can be deployed to Cloudflare workers using the open-next Cloudflare adapter
The app does seem to work as intended for the most part:
Deployment URL: https://nodejs-website.web-experiments.workers.dev
Warning
The PR is currently a single commit (ish), I am planning to force push (with
--force-with-lease) any new changes and keep this a single commit PR for now (so that it's easier to manage and rebase), if that's too annoying problematic for reviewers please let me know and I can just push standard commits if strongly preferredCheck List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.