Docs: add n as community download option #7498

shadowspawn · 2025-02-15T22:34:23Z

Description

Add n as a download method for Node.js.

Related issues in n and n-install projects:

Validation

Related Issues

Check List

I have read the Contributing Guidelines and made commit messages that follow the guideline.
I have run npm run format to ensure the code follows the style guide.
I have run npm run test to check if all tests are passing.
I have run npx turbo build to check if the website builds without errors.
I've covered new added functionality with unit tests if necessary.

vercel · 2025-02-15T22:34:27Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Mar 25, 2025 11:42pm

apps/site/components/Icons/InstallationMethod/N.tsx

apps/site/snippets/en/download/n.bash

benhalverson

apps/site/snippets/en/download/n.bash

apps/site/components/Icons/InstallationMethod/N.tsx

AugustinMauroy

LGMT !

bjohansebas

LGTM

apps/site/snippets/en/download/n.bash

ovflowd

@shadowspawn waiting for you to update the copies and then we're good to go!

avivkeller

LGTM!

github-actions · 2025-03-22T20:22:19Z

Lighthouse Results

URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟢 100	🟢 100	🟢 100	🟢 91	🔗
/en/about	🟢 100	🟢 100	🟢 100	🟢 91	🔗
/en/about/previous-releases	🟢 100	🟢 100	🟢 100	🟢 92	🔗
/en/download	🔴 74	🟢 100	🟢 100	🟢 91	🔗
/en/blog	🟢 100	🟢 100	🟢 96	🟢 92	🔗

github-actions · 2025-03-22T20:23:19Z

Unit Test Coverage Report

Title	Lines	Statements	Branches	Functions
@node-core/ui-components		95.83% (161/168)	77.86% (102/131)	88.57% (31/35)
@nodejs/website		84.74% (500/590)	76.03% (165/217)	87.09% (108/124)

Title	Tests	Skipped	Failures	Errors	Time
@node-core/ui-components	24	0 💤	0 ❌	0 🔥	4.216s ⏱️
@nodejs/website	157	0 💤	0 ❌	0 🔥	6.172s ⏱️

avivkeller · 2025-03-22T20:24:23Z

update the copies and then we're good to go!

What copies? nvm only exists on bash.

avivkeller · 2025-03-22T20:44:19Z

My only nitpick/concern is that the MacOS close/min/max buttons don't appear to be contained within the logo's content, and there appears to be a white border (https://snapshots.chromatic.com/snapshots/64c7d71358830e9105808652-67df1c3434d85d3bf91872e0/capture-b3e22694.png). If this is intentional, ignore this comment, however if it's not intentional, maybe some slight adjustments could improve this?

i.e.

<svg
    width="100%"
    height="100%"
    viewBox="0 0 64 64"
    xmlns="http://www.w3.org/2000/svg"
>
    <rect width="64" height="64" rx="8" fill="#121212"/>

    <circle cx="10" cy="10" r="4" fill="#ff5f56"/>  <!-- Close -->
    <circle cx="20" cy="10" r="4" fill="#ffbd2e"/>  <!-- Minimize -->
    <circle cx="30" cy="10" r="4" fill="#27c93f"/>  <!-- Maximize -->

    <text x="16" y="44" font-family="monospace" font-size="32" font-weight="bold" fill="#00ff7f">
        $n
    </text>
</svg>

shadowspawn · 2025-03-23T02:40:29Z

The white border was intended so icon identifiable on a black background.

The buttons positions were not done carefully, good call on questioning those.

I will take a look when back at a computer.

shadowspawn · 2025-03-23T10:23:52Z

Improved button positions in icon following suggestion.

avivkeller · 2025-03-23T11:32:25Z

Improved button positions in icon following suggestion.

Thanks! Looks good (https://64c7d71358830e9105808652-yhorhypche.chromatic.com/?path=/story/design-system--platform-logos&globals=viewport:large)!

avivkeller · 2025-03-25T14:45:09Z

Hey, @shadowspawn! We recently merged some changes, if you could rebase please.

I'm here to help you if needed, but once that's done I'd be happy to merge this!

packages/ui-components/Icons/InstallationMethod/N.tsx

ovflowd

LGTM

shadowspawn · 2025-03-25T23:40:04Z

I manually rebased PR (automated rebase went badly).

I noticed Volta was missing from packages/ui-components/__design__/platform-logos.stories.tsx (which is not mentioned in the collaboration guide) and added both n and Volta.

shadowspawn requested a review from a team as a code owner February 15, 2025 22:34

vercel bot deployed to Preview February 15, 2025 22:35 View deployment

shadowspawn mentioned this pull request Feb 15, 2025

Show n-install for installing n on Node.js downloads page tj/n#829

Closed

AugustinMauroy reviewed Feb 16, 2025

View reviewed changes

apps/site/components/Icons/InstallationMethod/N.tsx Outdated Show resolved Hide resolved

apps/site/snippets/en/download/n.bash Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview February 16, 2025 11:41 View deployment

benhalverson approved these changes Feb 16, 2025

View reviewed changes

vercel bot deployed to Preview February 17, 2025 09:09 View deployment

vercel bot deployed to Preview February 18, 2025 07:51 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview February 20, 2025 21:36 View deployment

benhalverson enabled auto-merge February 21, 2025 05:43

bjohansebas reviewed Feb 22, 2025

View reviewed changes

apps/site/snippets/en/download/n.bash Outdated Show resolved Hide resolved

auto-merge was automatically disabled February 24, 2025 06:44
Head branch was pushed to by a user without write access

vercel bot deployed to Preview February 24, 2025 06:45 View deployment

AugustinMauroy reviewed Mar 4, 2025

View reviewed changes

apps/site/components/Icons/InstallationMethod/N.tsx Outdated Show resolved Hide resolved

AugustinMauroy approved these changes Mar 4, 2025

View reviewed changes

bjohansebas reviewed Mar 4, 2025

View reviewed changes

avivkeller reviewed Mar 19, 2025

View reviewed changes

apps/site/snippets/en/download/n.bash Outdated Show resolved Hide resolved

ovflowd approved these changes Mar 22, 2025

View reviewed changes

vercel bot deployed to Preview March 22, 2025 19:43 View deployment

avivkeller approved these changes Mar 22, 2025

View reviewed changes

avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Mar 22, 2025

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 22, 2025

avivkeller deployed to Storybook March 22, 2025 20:21 — with GitHub Actions View deployment

avivkeller enabled auto-merge March 22, 2025 20:22

avivkeller disabled auto-merge March 22, 2025 20:22

vercel bot deployed to Preview March 23, 2025 10:18 View deployment

avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Mar 23, 2025

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 23, 2025

avivkeller deployed to Storybook March 23, 2025 11:32 — with GitHub Actions View deployment

aymen94 approved these changes Mar 25, 2025

View reviewed changes

shadowspawn added 2 commits March 26, 2025 12:19

Docs: add n as community download option

9623bee

Chore: add new download methods to stories

e4235a9

shadowspawn force-pushed the add-n-download-method branch from 55570e2 to e4235a9 Compare March 25, 2025 23:33

vercel bot deployed to Preview March 25, 2025 23:34 View deployment

ovflowd reviewed Mar 25, 2025

View reviewed changes

packages/ui-components/Icons/InstallationMethod/N.tsx Outdated Show resolved Hide resolved

ovflowd approved these changes Mar 25, 2025

View reviewed changes

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Mar 25, 2025

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 25, 2025

ovflowd deployed to Storybook March 25, 2025 23:40 — with GitHub Actions View deployment

Chore: remove inline comments per feedback

b1f8157

vercel bot deployed to Preview March 25, 2025 23:42 View deployment

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Mar 26, 2025

ovflowd enabled auto-merge March 26, 2025 22:40

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 26, 2025

ovflowd deployed to Storybook March 26, 2025 22:40 — with GitHub Actions View deployment

ovflowd added this pull request to the merge queue Mar 26, 2025

Merged via the queue into nodejs:main with commit 7754280 Mar 26, 2025
13 of 15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Docs: add n as community download option #7498

Docs: add n as community download option #7498

shadowspawn commented Feb 15, 2025 •

edited

Loading

vercel bot commented Feb 15, 2025 •

edited

Loading

This comment was marked as outdated.

benhalverson left a comment

This comment was marked as outdated.

AugustinMauroy left a comment

bjohansebas left a comment

ovflowd left a comment

avivkeller left a comment

github-actions bot commented Mar 22, 2025 •

edited

Loading

github-actions bot commented Mar 22, 2025 •

edited

Loading

avivkeller commented Mar 22, 2025

avivkeller commented Mar 22, 2025 •

edited

Loading

shadowspawn commented Mar 23, 2025

shadowspawn commented Mar 23, 2025

avivkeller commented Mar 23, 2025 •

edited

Loading

avivkeller commented Mar 25, 2025

ovflowd left a comment

shadowspawn commented Mar 25, 2025

Docs: add n as community download option #7498

Docs: add n as community download option #7498

Conversation

shadowspawn commented Feb 15, 2025 • edited Loading

Description

Validation

Related Issues

Check List

vercel bot commented Feb 15, 2025 • edited Loading

This comment was marked as outdated.

benhalverson left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

AugustinMauroy left a comment

Choose a reason for hiding this comment

bjohansebas left a comment

Choose a reason for hiding this comment

ovflowd left a comment

Choose a reason for hiding this comment

avivkeller left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 22, 2025 • edited Loading

github-actions bot commented Mar 22, 2025 • edited Loading

Unit Test Coverage Report

avivkeller commented Mar 22, 2025

avivkeller commented Mar 22, 2025 • edited Loading

shadowspawn commented Mar 23, 2025

shadowspawn commented Mar 23, 2025

avivkeller commented Mar 23, 2025 • edited Loading

avivkeller commented Mar 25, 2025

ovflowd left a comment

Choose a reason for hiding this comment

shadowspawn commented Mar 25, 2025

shadowspawn commented Feb 15, 2025 •

edited

Loading

vercel bot commented Feb 15, 2025 •

edited

Loading

github-actions bot commented Mar 22, 2025 •

edited

Loading

github-actions bot commented Mar 22, 2025 •

edited

Loading

avivkeller commented Mar 22, 2025 •

edited

Loading

avivkeller commented Mar 23, 2025 •

edited

Loading