Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: tailwind v4 #7507

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Conversation

bjohansebas
Copy link
Member

Description

Updated to Tailwind 4 :), still a work in progress

Check List

  • [] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [] I have run npm run format to ensure the code follows the style guide.
  • [] I have run npm run test to check if all tests are passing.
  • [] I have run npx turbo build to check if the website builds without errors.
  • [] I've covered new added functionality with unit tests if necessary.

Copy link

vercel bot commented Feb 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 22, 2025 2:42am

@AugustinMauroy
Copy link
Member

something that may help you:

npx @tailwindcss/upgrade

and for css module: https://tailwindcss.com/docs/compatibility#css-modules

@bjohansebas
Copy link
Member Author

Yep, with that I made the first commit, I thought it was going to do most of the work

Copy link
Contributor

Note

Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project.
We recommend giving a read on our Translation Guidelines.

Thank you!

@ovflowd
Copy link
Member

ovflowd commented Mar 1, 2025

Hey @bjohansebas I assume this is still a WIP?

Copy link
Contributor

github-actions bot commented Mar 1, 2025

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 90%
88.75% (742/836) 76.1% (242/318) 87.65% (142/162)

Unit Test Report

Tests Skipped Failures Errors Time
182 0 💤 0 ❌ 0 🔥 5.808s ⏱️

@bjohansebas
Copy link
Member Author

Yep, I'll continue with this later.

@ovflowd
Copy link
Member

ovflowd commented Mar 1, 2025

Yep, I'll continue with this later.

tysm for your contributions <3

@bjohansebas
Copy link
Member Author

I think I'll continue after you all have done the migration to the new version of Next.js.

@AugustinMauroy
Copy link
Member

@bjohansebas bump claudio had merge the pr. You can have fun with git conflict 😁

@avivkeller
Copy link
Member

avivkeller commented Mar 22, 2025

Just reviewed the visual tests, and it looks like the following noticeably different changes have occurred:

Description Link
Shadow removed View Test
Color missing View Test
Sizes changed View Test

I've also noticed that when clicking headers, they turn green. They didn't do that before.

@avivkeller
Copy link
Member

avivkeller commented Mar 22, 2025

Hey! I just wanted to give you a heads-up that I’m putting this PR on hold until #7401 merges. That one already has approval, no conflicts, and I’m planning to merge it on Monday, unless something unexpected comes up.

I don’t think this PR will be able to merge before then, so I’m marking it as "on hold" for now. That said, feel free to keep working on it—this just means it won’t be merged until #7401 lands.

Thanks for your patience! 😊


The CSS files in the ui-components library are identical to the ones in apps/site, so it should be as simple as moving the files to rebase, but if you need help, I'm available to take a look.

@bjohansebas
Copy link
Member Author

I would still need to rebase to resolve the conflicts that exist at the moment. I'll wait until your PR is merged to do everything at once.

@avivkeller
Copy link
Member

Thanks for your patience, @bjohansebas! If you need any help rebasing, please let me know.

@bjohansebas
Copy link
Member Author

Sure, I plan to do the rebase this weekend, hopefully it won't be too hard.

Likewise, I'm going to squash all the commits to make the rebase easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants