-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(about): list official resources #7562
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Aviv Keller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- apps/site/pages/en/about/index.mdx: Language not supported
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
See the edited About page: https://nodejs-org-git-feat-official-resources-openjs.vercel.app/en/about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
cc @nodejs/tsc as this is content updates. I feel confident with these updates, but just pining y'all in. |
### Official npm Packages | ||
|
||
The Node.js team maintains the following official npm package scopes: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about corepack, amaro, llhttp, etc...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, these do not have any @ within npm. Good catch. @marco-ippolito do you have a full list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those packages are published under the nodejs-foundation
account, which is listed right under the list of scopes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont see amaro or undici in there 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I guess those two weren't published from the foundation account. If you have a list of packages that belong to the organization, I'll check if they are published under the foundation account, and if not I'll add them to this list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
I've removed mention to other packages for now. If it's agreed upon that they should be listed, and someone can provide a definitive list, I'll add them into this PR. Also see nodejs/admin#959 |
Description
This PR lists official resources on the “About” page, so that users are steered away from unofficial, and possibly dangerous, resources.
I’m not sure if the TSC needs to sign off on this, to make sure that everything that should be included is.
Validation
Check the “About” page for the added information
Related Issues
Fixes #7050
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.