fix(crowdin): workflow improvements #7755
Open
+207
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7755 +/- ##
==========================================
+ Coverage 74.85% 74.87% +0.01%
==========================================
Files 98 98
Lines 7895 7895
Branches 200 200
==========================================
+ Hits 5910 5911 +1
+ Misses 1984 1983 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chore: sync translations from crowdin Signed-off-by: nodejs-crowdin <[email protected]> Co-authored-by: nodejs-crowdin <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on fixing bugs and improving the Crowdin workflow by updating translation keys in locale files, enhancing MDX content for the About pages, and refining the GitHub translations sync workflow.
- Updated translation JSON files (zh-tw and uk) with new keys and revised content.
- Modified MDX pages to improve layout, accessibility, and resource information.
- Refactored the translations sync GitHub workflow for better branch naming, commit handling, and overall operational reliability.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/i18n/locales/zh-tw.json | Added new translation keys and restructured release information. |
| packages/i18n/locales/uk.json | Synchronized new translation keys and updated copy for release details. |
| apps/site/pages/zh-tw/about/branding.mdx | Upgraded layout structure, enhanced image references, and credited contributor. |
| apps/site/pages/uk/about/previous-releases.mdx | Revised content to clarify official vs. community installation methods. |
| apps/site/pages/uk/about/index.mdx | Introduced additional sections for official Node.js resources and communication channels. |
| .github/workflows/translations-sync.yml | Refined workflow job names, branch handling, and commit process for translation updates. |
|
I combined this with the weekly translate run do demo the new, working script. |
AugustinMauroy
approved these changes
May 17, 2025
|
@nodejs/web-infra can I get some approvals on your end 😃? Thanks! |
ovflowd
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few bugs in, and hardens, the Crowdin workflow.