Node v18.20.8 nsolid v5.7.3 release#432
Open
santigimeno wants to merge 11 commits intonode-v18.x-nsolid-v5.xfrom
Open
Node v18.20.8 nsolid v5.7.3 release#432santigimeno wants to merge 11 commits intonode-v18.x-nsolid-v5.xfrom
santigimeno wants to merge 11 commits intonode-v18.x-nsolid-v5.xfrom
Conversation
Also, make all our existing agents code to use it. Ideally having an API like this being exposed from the `node::crypto` namespace (crypto_context specifically) would be ideal, but for the time being this should do. PR-URL: #340 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan for PR comments
Comment |
RafaelGSS
approved these changes
Mar 11, 2026
PR-URL: #346 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #290 Refs: nodesource/ebpf-roadmap#1 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Specifically in `EnvInst::CustomCommandReqWeakCallback()` when trying to access `EnvInst` associated with the `Isolate`. Observed when load-testing the `test/addons/nsolid-custom-command` test.
It wasn't added when creating the gRPC agent. Improved tests to cover this specific issue so it doesn't happen again. PR-URL: #413 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Make sure we take `service.version` into account once the fix for `appVersion` was introduced. Make sure we use the common `checkResource()` function in the tracing test too. PR-URL: #421 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
When trying to reset a CommandStream because of reasons: for example, we change `grpc` endpoint dynamically, we can enter an infinite recursion calling `GrpcAgent::reset_command_stream()` because when calling `~CommandStream()` the `OnDone()` callback may call the observer (GrpcAgent instance) which in turn would call `GrpcAgent::reset_command_stream()`. Avoid this recursion by adding a new `cancelling_for_destruction_` member variable to `CommandStream` which allows avoiding calling the observer if triggered by the destructor. PR-URL: #412 Reviewed-By: EHortua <55801532+EHortua@users.noreply.github.com>
santigimeno
force-pushed
the
node-v18.20.8-nsolid-v5.7.3-release
branch
from
6798d14 to
09f0542
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.