deps: update to protobuf v34.0#433
Open
santigimeno wants to merge 1 commit intonode-v24.x-nsolid-v6.xfrom
Open
deps: update to protobuf v34.0#433santigimeno wants to merge 1 commit intonode-v24.x-nsolid-v6.xfrom
santigimeno wants to merge 1 commit intonode-v24.x-nsolid-v6.xfrom
Conversation
WalkthroughGenerated protobuf C++ code and protobuf runtime files upgraded from gencode 6.33.2 → 7.34.0: Impl_ constructors gain InternalVisibility, many ConstantInitialized constructors made constexpr, [[nodiscard]] and PROTOBUF_FUTURE_ADD_EARLY_WARN_UNUSED annotations added, arena/repeated-field initialization and class-data dtor entries adjusted; build/tooling files updated accordingly. Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests (beta)
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
agents/grpc/src/proto/source_code.pb.h (1)
14-20:⚠️ Potential issue | 🟠 MajorAdd
--cpp_opt=proto_h=falseto the protoc regeneration command.The current
regenerate_proto_agents()function intools/dep_updaters/utils.shdoes not pass--cpp_opt=proto_h=falseto protoc. Protobuf 34 defaults to generating thin.proto.hheaders instead of full.pb.hfiles; without the explicit flag, the next regeneration may produce incompatible artifacts or fail to generate expected files, even though the version guard on line 16 only prevents runtime mismatches.Add
--cpp_opt=proto_h=falseto the protoc invocation inregenerate_proto_agents()to ensure consistent.pb.hgeneration across toolchain updates.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@agents/grpc/src/proto/source_code.pb.h` around lines 14 - 20, The protoc invocation in regenerate_proto_agents() (in tools/dep_updaters/utils.sh) must include the C++ option to force full .pb.h generation; update the function so the protoc command adds --cpp_opt=proto_h=false to its flags (alongside existing --cpp_out etc.) to prevent generation of thin .proto.h headers and ensure consistent .pb.h outputs across Protobuf 34+ toolchains.deps/protobuf/src/google/protobuf/arena.h (1)
797-821:⚠️ Potential issue | 🔴 CriticalMake
CopyConstruct()arena-representation-aware.
DefaultConstruct()now allocatesFieldArenaRep<T>::TypewhenFieldHasArenaOffset<T>()is true, butCopyConstruct()still always allocatessizeof(T)and constructs a bareT. That means copied arena-backed objects can bypass the wrapper path thatDoCreateMessage()andDefaultConstruct()now rely on, which is a correctness bug for any message/field type using an alternate arena representation.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@deps/protobuf/src/google/protobuf/arena.h` around lines 797 - 821, CopyConstruct currently always allocates sizeof(T) and constructs a bare T (via AllocateAligned(sizeof(T)) and new (mem) T(...)), which breaks types that use an alternate arena representation; change CopyConstruct to mirror DefaultConstruct/DoCreateMessage by checking FieldHasArenaOffset<T>() and, when true, allocate sizeof(FieldArenaRep<T>::Type) (via AllocateAligned) and construct the arena-wrapper type instead of T; when FieldHasArenaOffset<T>() is false, keep the existing allocation/placement-new of T; update the construction to use the wrapper type's constructor/copy path so arena-backed objects follow the same representation as DefaultConstruct and DoCreateMessage.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@agents/grpc/src/proto/source_code.pb.h`:
- Around line 14-20: The protoc invocation in regenerate_proto_agents() (in
tools/dep_updaters/utils.sh) must include the C++ option to force full .pb.h
generation; update the function so the protoc command adds
--cpp_opt=proto_h=false to its flags (alongside existing --cpp_out etc.) to
prevent generation of thin .proto.h headers and ensure consistent .pb.h outputs
across Protobuf 34+ toolchains.
In `@deps/protobuf/src/google/protobuf/arena.h`:
- Around line 797-821: CopyConstruct currently always allocates sizeof(T) and
constructs a bare T (via AllocateAligned(sizeof(T)) and new (mem) T(...)), which
breaks types that use an alternate arena representation; change CopyConstruct to
mirror DefaultConstruct/DoCreateMessage by checking FieldHasArenaOffset<T>()
and, when true, allocate sizeof(FieldArenaRep<T>::Type) (via AllocateAligned)
and construct the arena-wrapper type instead of T; when FieldHasArenaOffset<T>()
is false, keep the existing allocation/placement-new of T; update the
construction to use the wrapper type's constructor/copy path so arena-backed
objects follow the same representation as DefaultConstruct and DoCreateMessage.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6c04b14c-6034-416c-8046-4ba49c1b5d92
⛔ Files ignored due to path filters (16)
deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/collector/logs/v1/logs_service.pb.ccis excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/collector/logs/v1/logs_service.pb.his excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/collector/metrics/v1/metrics_service.pb.ccis excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/collector/metrics/v1/metrics_service.pb.his excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/collector/trace/v1/trace_service.pb.ccis excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/collector/trace/v1/trace_service.pb.his excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/common/v1/common.pb.ccis excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/common/v1/common.pb.his excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/logs/v1/logs.pb.ccis excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/logs/v1/logs.pb.his excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/metrics/v1/metrics.pb.ccis excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/metrics/v1/metrics.pb.his excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/resource/v1/resource.pb.ccis excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/resource/v1/resource.pb.his excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/trace/v1/trace.pb.ccis excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/trace/v1/trace.pb.his excluded by!**/gen/**
📒 Files selected for processing (284)
agents/grpc/src/proto/asset.pb.ccagents/grpc/src/proto/asset.pb.hagents/grpc/src/proto/blocked_loop.pb.ccagents/grpc/src/proto/blocked_loop.pb.hagents/grpc/src/proto/command.pb.ccagents/grpc/src/proto/command.pb.hagents/grpc/src/proto/common.pb.ccagents/grpc/src/proto/common.pb.hagents/grpc/src/proto/exit.pb.ccagents/grpc/src/proto/exit.pb.hagents/grpc/src/proto/info.pb.ccagents/grpc/src/proto/info.pb.hagents/grpc/src/proto/metrics.pb.ccagents/grpc/src/proto/metrics.pb.hagents/grpc/src/proto/nsolid_service.pb.ccagents/grpc/src/proto/nsolid_service.pb.hagents/grpc/src/proto/packages.pb.ccagents/grpc/src/proto/packages.pb.hagents/grpc/src/proto/profile.pb.ccagents/grpc/src/proto/profile.pb.hagents/grpc/src/proto/reconfigure.pb.ccagents/grpc/src/proto/reconfigure.pb.hagents/grpc/src/proto/source_code.pb.ccagents/grpc/src/proto/source_code.pb.hagents/grpc/src/proto/startup_times.pb.ccagents/grpc/src/proto/startup_times.pb.hdeps/protobuf/.bazelci/presubmit.ymldeps/protobuf/.bcr/metadata.template.jsondeps/protobuf/.bcr/presubmit.ymldeps/protobuf/.bcr/source.template.jsondeps/protobuf/.gitattributesdeps/protobuf/protobuf.gypdeps/protobuf/src/BUILD.bazeldeps/protobuf/src/file_lists.cmakedeps/protobuf/src/google/protobuf/BUILD.bazeldeps/protobuf/src/google/protobuf/any.hdeps/protobuf/src/google/protobuf/any.pb.ccdeps/protobuf/src/google/protobuf/any.pb.hdeps/protobuf/src/google/protobuf/api.pb.ccdeps/protobuf/src/google/protobuf/api.pb.hdeps/protobuf/src/google/protobuf/arena.hdeps/protobuf/src/google/protobuf/arenaz_sampler.hdeps/protobuf/src/google/protobuf/compiler/BUILD.bazeldeps/protobuf/src/google/protobuf/compiler/annotation_test_util.ccdeps/protobuf/src/google/protobuf/compiler/annotation_test_util.hdeps/protobuf/src/google/protobuf/compiler/code_generator.ccdeps/protobuf/src/google/protobuf/compiler/code_generator.hdeps/protobuf/src/google/protobuf/compiler/code_generator_unittest.ccdeps/protobuf/src/google/protobuf/compiler/command_line_interface.ccdeps/protobuf/src/google/protobuf/compiler/command_line_interface.hdeps/protobuf/src/google/protobuf/compiler/command_line_interface_unittest.ccdeps/protobuf/src/google/protobuf/compiler/cpp/BUILD.bazeldeps/protobuf/src/google/protobuf/compiler/cpp/bootstrap_unittest.ccdeps/protobuf/src/google/protobuf/compiler/cpp/enum.ccdeps/protobuf/src/google/protobuf/compiler/cpp/extension.ccdeps/protobuf/src/google/protobuf/compiler/cpp/extension.hdeps/protobuf/src/google/protobuf/compiler/cpp/field.ccdeps/protobuf/src/google/protobuf/compiler/cpp/field.hdeps/protobuf/src/google/protobuf/compiler/cpp/field_generators/cord_field.ccdeps/protobuf/src/google/protobuf/compiler/cpp/field_generators/enum_field.ccdeps/protobuf/src/google/protobuf/compiler/cpp/field_generators/generators.hdeps/protobuf/src/google/protobuf/compiler/cpp/field_generators/map_field.ccdeps/protobuf/src/google/protobuf/compiler/cpp/field_generators/message_field.ccdeps/protobuf/src/google/protobuf/compiler/cpp/field_generators/primitive_field.ccdeps/protobuf/src/google/protobuf/compiler/cpp/field_generators/string_field.ccdeps/protobuf/src/google/protobuf/compiler/cpp/field_generators/string_view_field.ccdeps/protobuf/src/google/protobuf/compiler/cpp/file.ccdeps/protobuf/src/google/protobuf/compiler/cpp/file.hdeps/protobuf/src/google/protobuf/compiler/cpp/file_unittest.ccdeps/protobuf/src/google/protobuf/compiler/cpp/generator.ccdeps/protobuf/src/google/protobuf/compiler/cpp/generator.hdeps/protobuf/src/google/protobuf/compiler/cpp/generator_unittest.ccdeps/protobuf/src/google/protobuf/compiler/cpp/helpers.ccdeps/protobuf/src/google/protobuf/compiler/cpp/helpers.hdeps/protobuf/src/google/protobuf/compiler/cpp/ifndef_guard_unittest.ccdeps/protobuf/src/google/protobuf/compiler/cpp/message.ccdeps/protobuf/src/google/protobuf/compiler/cpp/message.hdeps/protobuf/src/google/protobuf/compiler/cpp/message_layout_helper.ccdeps/protobuf/src/google/protobuf/compiler/cpp/message_layout_helper.hdeps/protobuf/src/google/protobuf/compiler/cpp/message_size_unittest.ccdeps/protobuf/src/google/protobuf/compiler/cpp/metadata_test.ccdeps/protobuf/src/google/protobuf/compiler/cpp/namespace_printer_unittest.ccdeps/protobuf/src/google/protobuf/compiler/cpp/options.hdeps/protobuf/src/google/protobuf/compiler/cpp/padding_optimizer.hdeps/protobuf/src/google/protobuf/compiler/cpp/parse_function_generator.ccdeps/protobuf/src/google/protobuf/compiler/cpp/parse_function_generator.hdeps/protobuf/src/google/protobuf/compiler/cpp/tools/analyze_profile_proto.ccdeps/protobuf/src/google/protobuf/compiler/cpp/tools/analyze_profile_proto_main.ccdeps/protobuf/src/google/protobuf/compiler/cpp/tracker.ccdeps/protobuf/src/google/protobuf/compiler/cpp/unittest.incdeps/protobuf/src/google/protobuf/compiler/csharp/BUILD.bazeldeps/protobuf/src/google/protobuf/compiler/csharp/csharp_enum.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_enum_field.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_field_base.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_field_base.hdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_generator.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_generator.hdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_helpers.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_helpers.hdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_map_field.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_message.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_message.hdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_message_field.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_primitive_field.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_repeated_enum_field.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_repeated_message_field.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_repeated_primitive_field.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_source_generator_base.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_wrapper_field.ccdeps/protobuf/src/google/protobuf/compiler/importer.ccdeps/protobuf/src/google/protobuf/compiler/importer.hdeps/protobuf/src/google/protobuf/compiler/java/BUILD.bazeldeps/protobuf/src/google/protobuf/compiler/java/doc_comment.ccdeps/protobuf/src/google/protobuf/compiler/java/field_common.ccdeps/protobuf/src/google/protobuf/compiler/java/file.ccdeps/protobuf/src/google/protobuf/compiler/java/full/BUILD.bazeldeps/protobuf/src/google/protobuf/compiler/java/full/enum.ccdeps/protobuf/src/google/protobuf/compiler/java/full/map_field.ccdeps/protobuf/src/google/protobuf/compiler/java/full/message.ccdeps/protobuf/src/google/protobuf/compiler/java/full/message_builder.ccdeps/protobuf/src/google/protobuf/compiler/java/full/message_field.ccdeps/protobuf/src/google/protobuf/compiler/java/full/message_field.hdeps/protobuf/src/google/protobuf/compiler/java/full/string_field.ccdeps/protobuf/src/google/protobuf/compiler/java/generator.ccdeps/protobuf/src/google/protobuf/compiler/java/generator.hdeps/protobuf/src/google/protobuf/compiler/java/generator_unittest.ccdeps/protobuf/src/google/protobuf/compiler/java/internal_helpers.ccdeps/protobuf/src/google/protobuf/compiler/java/internal_helpers.hdeps/protobuf/src/google/protobuf/compiler/java/java_features.pb.ccdeps/protobuf/src/google/protobuf/compiler/java/java_features.pb.hdeps/protobuf/src/google/protobuf/compiler/java/lite/enum.ccdeps/protobuf/src/google/protobuf/compiler/java/lite/message.ccdeps/protobuf/src/google/protobuf/compiler/java/lite/message_builder.ccdeps/protobuf/src/google/protobuf/compiler/java/plugin_unittest.ccdeps/protobuf/src/google/protobuf/compiler/java/shared_code_generator.ccdeps/protobuf/src/google/protobuf/compiler/kotlin/BUILD.bazeldeps/protobuf/src/google/protobuf/compiler/kotlin/annotation_test.ccdeps/protobuf/src/google/protobuf/compiler/kotlin/field.ccdeps/protobuf/src/google/protobuf/compiler/kotlin/file.ccdeps/protobuf/src/google/protobuf/compiler/kotlin/file.hdeps/protobuf/src/google/protobuf/compiler/kotlin/generator.ccdeps/protobuf/src/google/protobuf/compiler/kotlin/generator.hdeps/protobuf/src/google/protobuf/compiler/kotlin/message.ccdeps/protobuf/src/google/protobuf/compiler/main.ccdeps/protobuf/src/google/protobuf/compiler/objectivec/BUILD.bazeldeps/protobuf/src/google/protobuf/compiler/objectivec/extension.ccdeps/protobuf/src/google/protobuf/compiler/objectivec/extension.hdeps/protobuf/src/google/protobuf/compiler/objectivec/field.ccdeps/protobuf/src/google/protobuf/compiler/objectivec/file.ccdeps/protobuf/src/google/protobuf/compiler/objectivec/file.hdeps/protobuf/src/google/protobuf/compiler/objectivec/generator.ccdeps/protobuf/src/google/protobuf/compiler/objectivec/generator.hdeps/protobuf/src/google/protobuf/compiler/objectivec/message.ccdeps/protobuf/src/google/protobuf/compiler/objectivec/message.hdeps/protobuf/src/google/protobuf/compiler/objectivec/names.ccdeps/protobuf/src/google/protobuf/compiler/objectivec/names.hdeps/protobuf/src/google/protobuf/compiler/objectivec/options.hdeps/protobuf/src/google/protobuf/compiler/parser.ccdeps/protobuf/src/google/protobuf/compiler/parser.hdeps/protobuf/src/google/protobuf/compiler/parser_unittest.ccdeps/protobuf/src/google/protobuf/compiler/php/BUILDdeps/protobuf/src/google/protobuf/compiler/php/php_generator.ccdeps/protobuf/src/google/protobuf/compiler/php/php_generator.hdeps/protobuf/src/google/protobuf/compiler/plugin.pb.ccdeps/protobuf/src/google/protobuf/compiler/plugin.pb.hdeps/protobuf/src/google/protobuf/compiler/python/BUILD.bazeldeps/protobuf/src/google/protobuf/compiler/python/generator.ccdeps/protobuf/src/google/protobuf/compiler/python/generator.hdeps/protobuf/src/google/protobuf/compiler/python/pyi_generator.ccdeps/protobuf/src/google/protobuf/compiler/python/pyi_generator.hdeps/protobuf/src/google/protobuf/compiler/retention_unittest.ccdeps/protobuf/src/google/protobuf/compiler/ruby/BUILD.bazeldeps/protobuf/src/google/protobuf/compiler/ruby/rbs_generator.ccdeps/protobuf/src/google/protobuf/compiler/ruby/rbs_generator.hdeps/protobuf/src/google/protobuf/compiler/ruby/rbs_generator_unittest.ccdeps/protobuf/src/google/protobuf/compiler/ruby/ruby_generated_code.protodeps/protobuf/src/google/protobuf/compiler/ruby/ruby_generated_code_pb.rbsdeps/protobuf/src/google/protobuf/compiler/ruby/ruby_generated_code_proto2_pb.rbsdeps/protobuf/src/google/protobuf/compiler/ruby/ruby_generated_pkg_explicit_legacy_pb.rbsdeps/protobuf/src/google/protobuf/compiler/ruby/ruby_generated_pkg_explicit_pb.rbsdeps/protobuf/src/google/protobuf/compiler/ruby/ruby_generated_pkg_implicit_pb.rbsdeps/protobuf/src/google/protobuf/compiler/ruby/ruby_generator.ccdeps/protobuf/src/google/protobuf/compiler/ruby/ruby_generator.hdeps/protobuf/src/google/protobuf/compiler/rust/BUILDdeps/protobuf/src/google/protobuf/compiler/rust/accessors/BUILDdeps/protobuf/src/google/protobuf/compiler/rust/accessors/map.ccdeps/protobuf/src/google/protobuf/compiler/rust/accessors/repeated_field.ccdeps/protobuf/src/google/protobuf/compiler/rust/accessors/singular_cord.ccdeps/protobuf/src/google/protobuf/compiler/rust/accessors/singular_message.ccdeps/protobuf/src/google/protobuf/compiler/rust/accessors/singular_scalar.ccdeps/protobuf/src/google/protobuf/compiler/rust/accessors/singular_string.ccdeps/protobuf/src/google/protobuf/compiler/rust/context.ccdeps/protobuf/src/google/protobuf/compiler/rust/context.hdeps/protobuf/src/google/protobuf/compiler/rust/enum.ccdeps/protobuf/src/google/protobuf/compiler/rust/generator.ccdeps/protobuf/src/google/protobuf/compiler/rust/generator.hdeps/protobuf/src/google/protobuf/compiler/rust/message.ccdeps/protobuf/src/google/protobuf/compiler/rust/naming.ccdeps/protobuf/src/google/protobuf/compiler/rust/naming.hdeps/protobuf/src/google/protobuf/compiler/rust/rust_keywords.ccdeps/protobuf/src/google/protobuf/compiler/test_plugin_injection.bzldeps/protobuf/src/google/protobuf/compiler/versions.hdeps/protobuf/src/google/protobuf/cpp_features.pb.ccdeps/protobuf/src/google/protobuf/cpp_features.pb.hdeps/protobuf/src/google/protobuf/descriptor.ccdeps/protobuf/src/google/protobuf/descriptor.hdeps/protobuf/src/google/protobuf/descriptor.pb.ccdeps/protobuf/src/google/protobuf/descriptor.pb.hdeps/protobuf/src/google/protobuf/descriptor.protodeps/protobuf/src/google/protobuf/descriptor_database.ccdeps/protobuf/src/google/protobuf/descriptor_database.hdeps/protobuf/src/google/protobuf/descriptor_legacy.hdeps/protobuf/src/google/protobuf/descriptor_lite.hdeps/protobuf/src/google/protobuf/duration.pb.ccdeps/protobuf/src/google/protobuf/duration.pb.hdeps/protobuf/src/google/protobuf/dynamic_message.ccdeps/protobuf/src/google/protobuf/dynamic_message.hdeps/protobuf/src/google/protobuf/empty.pb.ccdeps/protobuf/src/google/protobuf/empty.pb.hdeps/protobuf/src/google/protobuf/endian.hdeps/protobuf/src/google/protobuf/explicitly_constructed.hdeps/protobuf/src/google/protobuf/extension_set.ccdeps/protobuf/src/google/protobuf/extension_set.hdeps/protobuf/src/google/protobuf/extension_set_heavy.ccdeps/protobuf/src/google/protobuf/extension_set_inl.hdeps/protobuf/src/google/protobuf/feature_resolver.ccdeps/protobuf/src/google/protobuf/feature_resolver.hdeps/protobuf/src/google/protobuf/field_access_listener.hdeps/protobuf/src/google/protobuf/field_mask.pb.ccdeps/protobuf/src/google/protobuf/field_mask.pb.hdeps/protobuf/src/google/protobuf/field_mask.protodeps/protobuf/src/google/protobuf/field_with_arena.hdeps/protobuf/src/google/protobuf/generated_enum_reflection.hdeps/protobuf/src/google/protobuf/generated_enum_util.ccdeps/protobuf/src/google/protobuf/generated_enum_util.hdeps/protobuf/src/google/protobuf/generated_message_reflection.ccdeps/protobuf/src/google/protobuf/generated_message_reflection.hdeps/protobuf/src/google/protobuf/generated_message_tctable_decl.hdeps/protobuf/src/google/protobuf/generated_message_tctable_gen.ccdeps/protobuf/src/google/protobuf/generated_message_tctable_gen.hdeps/protobuf/src/google/protobuf/generated_message_tctable_impl.hdeps/protobuf/src/google/protobuf/generated_message_tctable_lite.ccdeps/protobuf/src/google/protobuf/generated_message_util.ccdeps/protobuf/src/google/protobuf/generated_message_util.hdeps/protobuf/src/google/protobuf/has_bits.hdeps/protobuf/src/google/protobuf/implicit_weak_message.ccdeps/protobuf/src/google/protobuf/implicit_weak_message.hdeps/protobuf/src/google/protobuf/inlined_string_field.ccdeps/protobuf/src/google/protobuf/inlined_string_field.hdeps/protobuf/src/google/protobuf/internal_metadata_locator.hdeps/protobuf/src/google/protobuf/internal_visibility.hdeps/protobuf/src/google/protobuf/io/BUILD.bazeldeps/protobuf/src/google/protobuf/io/coded_stream.ccdeps/protobuf/src/google/protobuf/io/coded_stream.hdeps/protobuf/src/google/protobuf/io/coded_stream_unittest.ccdeps/protobuf/src/google/protobuf/io/gzip_stream.ccdeps/protobuf/src/google/protobuf/io/gzip_stream.hdeps/protobuf/src/google/protobuf/io/printer.ccdeps/protobuf/src/google/protobuf/io/printer.hdeps/protobuf/src/google/protobuf/io/printer_death_test.ccdeps/protobuf/src/google/protobuf/io/printer_unittest.ccdeps/protobuf/src/google/protobuf/io/strtod.hdeps/protobuf/src/google/protobuf/io/test_zero_copy_stream.hdeps/protobuf/src/google/protobuf/io/test_zero_copy_stream_test.ccdeps/protobuf/src/google/protobuf/io/zero_copy_sink.hdeps/protobuf/src/google/protobuf/io/zero_copy_stream.hdeps/protobuf/src/google/protobuf/io/zero_copy_stream_impl.ccdeps/protobuf/src/google/protobuf/io/zero_copy_stream_impl.hdeps/protobuf/src/google/protobuf/io/zero_copy_stream_impl_lite.ccdeps/protobuf/src/google/protobuf/io/zero_copy_stream_impl_lite.hdeps/protobuf/src/google/protobuf/io/zero_copy_stream_unittest.ccdeps/protobuf/src/google/protobuf/json/BUILD.bazeldeps/protobuf/src/google/protobuf/json/internal/descriptor_traits.hdeps/protobuf/src/google/protobuf/json/internal/lexer.ccdeps/protobuf/src/google/protobuf/json/internal/parser.ccdeps/protobuf/src/google/protobuf/json/internal/unparser.ccdeps/protobuf/src/google/protobuf/json/internal/unparser_traits.hdeps/protobuf/src/google/protobuf/json/internal/untyped_message.ccdeps/protobuf/src/google/protobuf/json/internal/untyped_message.hdeps/protobuf/src/google/protobuf/json/json.hdeps/protobuf/src/google/protobuf/json/json_test.ccdeps/protobuf/src/google/protobuf/map.ccdeps/protobuf/src/google/protobuf/map.hdeps/protobuf/src/google/protobuf/map_entry.h
💤 Files with no reviewable changes (1)
- deps/protobuf/src/BUILD.bazel
santigimeno
force-pushed
the
santi/upgrade_protobuf
branch
from
4d39de2 to
ea45868
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
deps/protobuf/src/file_lists.cmake (1)
82-1453:⚠️ Potential issue | 🔴 CriticalSeveral newly added file references do not exist in the repository and will cause build failures.
The following 27 files are referenced in the CMakeLists but are missing from the repository:
upb/mini_table/compat.c,upb/mini_table/debug_string.c,upb/mini_table/generated_registry.cupb/base/error_handler.h,upb/mini_table/compat.h,upb/mini_table/debug_string.h,upb/mini_table/generated_registry.h,upb/mini_table/internal/generated_registry.h,upb/wire/internal/eps_copy_input_stream.heditions/edition_defaults_test_utils.cc,editions/edition_defaults_test_utils.hsrc/google/protobuf/descriptor_test_utils.cc,src/google/protobuf/descriptor_test_utils.hupb/test/custom_options.proto,upb/test/test_multiple_files.proto,upb/test/test_multiple_files2.protoupb/hash/test.cc,upb/lex/atoi_test.cc,upb/lex/round_trip_test.cc,upb/mini_descriptor/internal/encode_test.cc,upb/mini_table/compat_test.cc,upb/mini_table/generated_registry_test.ccsrc/google/protobuf/field_with_arena_test.cc,src/google/protobuf/internal_metadata_locator_test.cc,src/google/protobuf/symbol_checker_test.ccsrc/google/protobuf/internal_metadata_locator_test.proto,src/google/protobuf/unittest_utf8_string_extensions.protosrc/google/protobuf/compiler/ruby/rbs_generator_unittest.ccsrc/google/protobuf/util/field_mask_util_test.protoThe CMake configuration will fail to locate these files during build. Ensure all referenced files are present in the vendored protobuf tree before merging.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@deps/protobuf/src/file_lists.cmake` around lines 82 - 1453, The CMake lists reference many files that are not present, causing build failures; update the diff in file_lists.cmake by either adding the missing source/header/proto/test files to the vendored protobuf tree or removing/guarding their entries so CMake won't reference non‑existent files (look for the sets that include the missing names such as libupb_srcs, libupb_hdrs, upb_test_protos_files, upb_test_files, protobuf_test_files, and the editions/ and src/google/protobuf entries like descriptor_test_utils and edition_defaults_test_utils); use conditional EXISTS checks or split optional test/source lists to avoid hard failures until the actual files are added.deps/protobuf/src/google/protobuf/BUILD.bazel (1)
1678-1703:⚠️ Potential issue | 🟡 MinorRemove
gtest_maindependency from this library.The
descriptor_test_utilsis acc_librarywithtestonly = True, but it should not depend ongtest_main. Thegtest_maintarget provides amain()function intended only forcc_testexecutable targets. Test utility libraries need onlygtestfor assertion macros. The cc_test targets that depend ondescriptor_test_utils(e.g.,descriptor_database_unittest) provide their owngtest_maindependency.♻️ Suggested fix
"@abseil-cpp//absl/strings", "@googletest//:gtest", - "@googletest//:gtest_main", ], )🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@deps/protobuf/src/google/protobuf/BUILD.bazel` around lines 1678 - 1703, The cc_library descriptor_test_utils should not depend on the gtest_main target; remove "@googletest//:gtest_main" from the deps of the descriptor_test_utils cc_library while keeping "@googletest//:gtest" so test utilities only provide assertions and do not pull in a main() implementation (update the deps list in the cc_library named "descriptor_test_utils").
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@deps/protobuf/src/file_lists.cmake`:
- Around line 82-1453: The CMake lists reference many files that are not
present, causing build failures; update the diff in file_lists.cmake by either
adding the missing source/header/proto/test files to the vendored protobuf tree
or removing/guarding their entries so CMake won't reference non‑existent files
(look for the sets that include the missing names such as libupb_srcs,
libupb_hdrs, upb_test_protos_files, upb_test_files, protobuf_test_files, and the
editions/ and src/google/protobuf entries like descriptor_test_utils and
edition_defaults_test_utils); use conditional EXISTS checks or split optional
test/source lists to avoid hard failures until the actual files are added.
In `@deps/protobuf/src/google/protobuf/BUILD.bazel`:
- Around line 1678-1703: The cc_library descriptor_test_utils should not depend
on the gtest_main target; remove "@googletest//:gtest_main" from the deps of the
descriptor_test_utils cc_library while keeping "@googletest//:gtest" so test
utilities only provide assertions and do not pull in a main() implementation
(update the deps list in the cc_library named "descriptor_test_utils").
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4cc25bac-ed2f-4b9e-9d5d-581e5217403f
⛔ Files ignored due to path filters (16)
deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/collector/logs/v1/logs_service.pb.ccis excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/collector/logs/v1/logs_service.pb.his excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/collector/metrics/v1/metrics_service.pb.ccis excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/collector/metrics/v1/metrics_service.pb.his excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/collector/trace/v1/trace_service.pb.ccis excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/collector/trace/v1/trace_service.pb.his excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/common/v1/common.pb.ccis excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/common/v1/common.pb.his excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/logs/v1/logs.pb.ccis excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/logs/v1/logs.pb.his excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/metrics/v1/metrics.pb.ccis excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/metrics/v1/metrics.pb.his excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/resource/v1/resource.pb.ccis excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/resource/v1/resource.pb.his excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/trace/v1/trace.pb.ccis excluded by!**/gen/**deps/opentelemetry-cpp/third_party/opentelemetry-proto/gen/cpp/opentelemetry/proto/trace/v1/trace.pb.his excluded by!**/gen/**
📒 Files selected for processing (284)
agents/grpc/src/proto/asset.pb.ccagents/grpc/src/proto/asset.pb.hagents/grpc/src/proto/blocked_loop.pb.ccagents/grpc/src/proto/blocked_loop.pb.hagents/grpc/src/proto/command.pb.ccagents/grpc/src/proto/command.pb.hagents/grpc/src/proto/common.pb.ccagents/grpc/src/proto/common.pb.hagents/grpc/src/proto/exit.pb.ccagents/grpc/src/proto/exit.pb.hagents/grpc/src/proto/info.pb.ccagents/grpc/src/proto/info.pb.hagents/grpc/src/proto/metrics.pb.ccagents/grpc/src/proto/metrics.pb.hagents/grpc/src/proto/nsolid_service.pb.ccagents/grpc/src/proto/nsolid_service.pb.hagents/grpc/src/proto/packages.pb.ccagents/grpc/src/proto/packages.pb.hagents/grpc/src/proto/profile.pb.ccagents/grpc/src/proto/profile.pb.hagents/grpc/src/proto/reconfigure.pb.ccagents/grpc/src/proto/reconfigure.pb.hagents/grpc/src/proto/source_code.pb.ccagents/grpc/src/proto/source_code.pb.hagents/grpc/src/proto/startup_times.pb.ccagents/grpc/src/proto/startup_times.pb.hdeps/protobuf/.bazelci/presubmit.ymldeps/protobuf/.bcr/metadata.template.jsondeps/protobuf/.bcr/presubmit.ymldeps/protobuf/.bcr/source.template.jsondeps/protobuf/.gitattributesdeps/protobuf/protobuf.gypdeps/protobuf/src/BUILD.bazeldeps/protobuf/src/file_lists.cmakedeps/protobuf/src/google/protobuf/BUILD.bazeldeps/protobuf/src/google/protobuf/any.hdeps/protobuf/src/google/protobuf/any.pb.ccdeps/protobuf/src/google/protobuf/any.pb.hdeps/protobuf/src/google/protobuf/api.pb.ccdeps/protobuf/src/google/protobuf/api.pb.hdeps/protobuf/src/google/protobuf/arena.hdeps/protobuf/src/google/protobuf/arenaz_sampler.hdeps/protobuf/src/google/protobuf/compiler/BUILD.bazeldeps/protobuf/src/google/protobuf/compiler/annotation_test_util.ccdeps/protobuf/src/google/protobuf/compiler/annotation_test_util.hdeps/protobuf/src/google/protobuf/compiler/code_generator.ccdeps/protobuf/src/google/protobuf/compiler/code_generator.hdeps/protobuf/src/google/protobuf/compiler/code_generator_unittest.ccdeps/protobuf/src/google/protobuf/compiler/command_line_interface.ccdeps/protobuf/src/google/protobuf/compiler/command_line_interface.hdeps/protobuf/src/google/protobuf/compiler/command_line_interface_unittest.ccdeps/protobuf/src/google/protobuf/compiler/cpp/BUILD.bazeldeps/protobuf/src/google/protobuf/compiler/cpp/bootstrap_unittest.ccdeps/protobuf/src/google/protobuf/compiler/cpp/enum.ccdeps/protobuf/src/google/protobuf/compiler/cpp/extension.ccdeps/protobuf/src/google/protobuf/compiler/cpp/extension.hdeps/protobuf/src/google/protobuf/compiler/cpp/field.ccdeps/protobuf/src/google/protobuf/compiler/cpp/field.hdeps/protobuf/src/google/protobuf/compiler/cpp/field_generators/cord_field.ccdeps/protobuf/src/google/protobuf/compiler/cpp/field_generators/enum_field.ccdeps/protobuf/src/google/protobuf/compiler/cpp/field_generators/generators.hdeps/protobuf/src/google/protobuf/compiler/cpp/field_generators/map_field.ccdeps/protobuf/src/google/protobuf/compiler/cpp/field_generators/message_field.ccdeps/protobuf/src/google/protobuf/compiler/cpp/field_generators/primitive_field.ccdeps/protobuf/src/google/protobuf/compiler/cpp/field_generators/string_field.ccdeps/protobuf/src/google/protobuf/compiler/cpp/field_generators/string_view_field.ccdeps/protobuf/src/google/protobuf/compiler/cpp/file.ccdeps/protobuf/src/google/protobuf/compiler/cpp/file.hdeps/protobuf/src/google/protobuf/compiler/cpp/file_unittest.ccdeps/protobuf/src/google/protobuf/compiler/cpp/generator.ccdeps/protobuf/src/google/protobuf/compiler/cpp/generator.hdeps/protobuf/src/google/protobuf/compiler/cpp/generator_unittest.ccdeps/protobuf/src/google/protobuf/compiler/cpp/helpers.ccdeps/protobuf/src/google/protobuf/compiler/cpp/helpers.hdeps/protobuf/src/google/protobuf/compiler/cpp/ifndef_guard_unittest.ccdeps/protobuf/src/google/protobuf/compiler/cpp/message.ccdeps/protobuf/src/google/protobuf/compiler/cpp/message.hdeps/protobuf/src/google/protobuf/compiler/cpp/message_layout_helper.ccdeps/protobuf/src/google/protobuf/compiler/cpp/message_layout_helper.hdeps/protobuf/src/google/protobuf/compiler/cpp/message_size_unittest.ccdeps/protobuf/src/google/protobuf/compiler/cpp/metadata_test.ccdeps/protobuf/src/google/protobuf/compiler/cpp/namespace_printer_unittest.ccdeps/protobuf/src/google/protobuf/compiler/cpp/options.hdeps/protobuf/src/google/protobuf/compiler/cpp/padding_optimizer.hdeps/protobuf/src/google/protobuf/compiler/cpp/parse_function_generator.ccdeps/protobuf/src/google/protobuf/compiler/cpp/parse_function_generator.hdeps/protobuf/src/google/protobuf/compiler/cpp/tools/analyze_profile_proto.ccdeps/protobuf/src/google/protobuf/compiler/cpp/tools/analyze_profile_proto_main.ccdeps/protobuf/src/google/protobuf/compiler/cpp/tracker.ccdeps/protobuf/src/google/protobuf/compiler/cpp/unittest.incdeps/protobuf/src/google/protobuf/compiler/csharp/BUILD.bazeldeps/protobuf/src/google/protobuf/compiler/csharp/csharp_enum.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_enum_field.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_field_base.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_field_base.hdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_generator.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_generator.hdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_helpers.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_helpers.hdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_map_field.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_message.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_message.hdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_message_field.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_primitive_field.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_repeated_enum_field.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_repeated_message_field.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_repeated_primitive_field.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_source_generator_base.ccdeps/protobuf/src/google/protobuf/compiler/csharp/csharp_wrapper_field.ccdeps/protobuf/src/google/protobuf/compiler/importer.ccdeps/protobuf/src/google/protobuf/compiler/importer.hdeps/protobuf/src/google/protobuf/compiler/java/BUILD.bazeldeps/protobuf/src/google/protobuf/compiler/java/doc_comment.ccdeps/protobuf/src/google/protobuf/compiler/java/field_common.ccdeps/protobuf/src/google/protobuf/compiler/java/file.ccdeps/protobuf/src/google/protobuf/compiler/java/full/BUILD.bazeldeps/protobuf/src/google/protobuf/compiler/java/full/enum.ccdeps/protobuf/src/google/protobuf/compiler/java/full/map_field.ccdeps/protobuf/src/google/protobuf/compiler/java/full/message.ccdeps/protobuf/src/google/protobuf/compiler/java/full/message_builder.ccdeps/protobuf/src/google/protobuf/compiler/java/full/message_field.ccdeps/protobuf/src/google/protobuf/compiler/java/full/message_field.hdeps/protobuf/src/google/protobuf/compiler/java/full/string_field.ccdeps/protobuf/src/google/protobuf/compiler/java/generator.ccdeps/protobuf/src/google/protobuf/compiler/java/generator.hdeps/protobuf/src/google/protobuf/compiler/java/generator_unittest.ccdeps/protobuf/src/google/protobuf/compiler/java/internal_helpers.ccdeps/protobuf/src/google/protobuf/compiler/java/internal_helpers.hdeps/protobuf/src/google/protobuf/compiler/java/java_features.pb.ccdeps/protobuf/src/google/protobuf/compiler/java/java_features.pb.hdeps/protobuf/src/google/protobuf/compiler/java/lite/enum.ccdeps/protobuf/src/google/protobuf/compiler/java/lite/message.ccdeps/protobuf/src/google/protobuf/compiler/java/lite/message_builder.ccdeps/protobuf/src/google/protobuf/compiler/java/plugin_unittest.ccdeps/protobuf/src/google/protobuf/compiler/java/shared_code_generator.ccdeps/protobuf/src/google/protobuf/compiler/kotlin/BUILD.bazeldeps/protobuf/src/google/protobuf/compiler/kotlin/annotation_test.ccdeps/protobuf/src/google/protobuf/compiler/kotlin/field.ccdeps/protobuf/src/google/protobuf/compiler/kotlin/file.ccdeps/protobuf/src/google/protobuf/compiler/kotlin/file.hdeps/protobuf/src/google/protobuf/compiler/kotlin/generator.ccdeps/protobuf/src/google/protobuf/compiler/kotlin/generator.hdeps/protobuf/src/google/protobuf/compiler/kotlin/message.ccdeps/protobuf/src/google/protobuf/compiler/main.ccdeps/protobuf/src/google/protobuf/compiler/objectivec/BUILD.bazeldeps/protobuf/src/google/protobuf/compiler/objectivec/extension.ccdeps/protobuf/src/google/protobuf/compiler/objectivec/extension.hdeps/protobuf/src/google/protobuf/compiler/objectivec/field.ccdeps/protobuf/src/google/protobuf/compiler/objectivec/file.ccdeps/protobuf/src/google/protobuf/compiler/objectivec/file.hdeps/protobuf/src/google/protobuf/compiler/objectivec/generator.ccdeps/protobuf/src/google/protobuf/compiler/objectivec/generator.hdeps/protobuf/src/google/protobuf/compiler/objectivec/message.ccdeps/protobuf/src/google/protobuf/compiler/objectivec/message.hdeps/protobuf/src/google/protobuf/compiler/objectivec/names.ccdeps/protobuf/src/google/protobuf/compiler/objectivec/names.hdeps/protobuf/src/google/protobuf/compiler/objectivec/options.hdeps/protobuf/src/google/protobuf/compiler/parser.ccdeps/protobuf/src/google/protobuf/compiler/parser.hdeps/protobuf/src/google/protobuf/compiler/parser_unittest.ccdeps/protobuf/src/google/protobuf/compiler/php/BUILDdeps/protobuf/src/google/protobuf/compiler/php/php_generator.ccdeps/protobuf/src/google/protobuf/compiler/php/php_generator.hdeps/protobuf/src/google/protobuf/compiler/plugin.pb.ccdeps/protobuf/src/google/protobuf/compiler/plugin.pb.hdeps/protobuf/src/google/protobuf/compiler/python/BUILD.bazeldeps/protobuf/src/google/protobuf/compiler/python/generator.ccdeps/protobuf/src/google/protobuf/compiler/python/generator.hdeps/protobuf/src/google/protobuf/compiler/python/pyi_generator.ccdeps/protobuf/src/google/protobuf/compiler/python/pyi_generator.hdeps/protobuf/src/google/protobuf/compiler/retention_unittest.ccdeps/protobuf/src/google/protobuf/compiler/ruby/BUILD.bazeldeps/protobuf/src/google/protobuf/compiler/ruby/rbs_generator.ccdeps/protobuf/src/google/protobuf/compiler/ruby/rbs_generator.hdeps/protobuf/src/google/protobuf/compiler/ruby/rbs_generator_unittest.ccdeps/protobuf/src/google/protobuf/compiler/ruby/ruby_generated_code.protodeps/protobuf/src/google/protobuf/compiler/ruby/ruby_generated_code_pb.rbsdeps/protobuf/src/google/protobuf/compiler/ruby/ruby_generated_code_proto2_pb.rbsdeps/protobuf/src/google/protobuf/compiler/ruby/ruby_generated_pkg_explicit_legacy_pb.rbsdeps/protobuf/src/google/protobuf/compiler/ruby/ruby_generated_pkg_explicit_pb.rbsdeps/protobuf/src/google/protobuf/compiler/ruby/ruby_generated_pkg_implicit_pb.rbsdeps/protobuf/src/google/protobuf/compiler/ruby/ruby_generator.ccdeps/protobuf/src/google/protobuf/compiler/ruby/ruby_generator.hdeps/protobuf/src/google/protobuf/compiler/rust/BUILDdeps/protobuf/src/google/protobuf/compiler/rust/accessors/BUILDdeps/protobuf/src/google/protobuf/compiler/rust/accessors/map.ccdeps/protobuf/src/google/protobuf/compiler/rust/accessors/repeated_field.ccdeps/protobuf/src/google/protobuf/compiler/rust/accessors/singular_cord.ccdeps/protobuf/src/google/protobuf/compiler/rust/accessors/singular_message.ccdeps/protobuf/src/google/protobuf/compiler/rust/accessors/singular_scalar.ccdeps/protobuf/src/google/protobuf/compiler/rust/accessors/singular_string.ccdeps/protobuf/src/google/protobuf/compiler/rust/context.ccdeps/protobuf/src/google/protobuf/compiler/rust/context.hdeps/protobuf/src/google/protobuf/compiler/rust/enum.ccdeps/protobuf/src/google/protobuf/compiler/rust/generator.ccdeps/protobuf/src/google/protobuf/compiler/rust/generator.hdeps/protobuf/src/google/protobuf/compiler/rust/message.ccdeps/protobuf/src/google/protobuf/compiler/rust/naming.ccdeps/protobuf/src/google/protobuf/compiler/rust/naming.hdeps/protobuf/src/google/protobuf/compiler/rust/rust_keywords.ccdeps/protobuf/src/google/protobuf/compiler/test_plugin_injection.bzldeps/protobuf/src/google/protobuf/compiler/versions.hdeps/protobuf/src/google/protobuf/cpp_features.pb.ccdeps/protobuf/src/google/protobuf/cpp_features.pb.hdeps/protobuf/src/google/protobuf/descriptor.ccdeps/protobuf/src/google/protobuf/descriptor.hdeps/protobuf/src/google/protobuf/descriptor.pb.ccdeps/protobuf/src/google/protobuf/descriptor.pb.hdeps/protobuf/src/google/protobuf/descriptor.protodeps/protobuf/src/google/protobuf/descriptor_database.ccdeps/protobuf/src/google/protobuf/descriptor_database.hdeps/protobuf/src/google/protobuf/descriptor_legacy.hdeps/protobuf/src/google/protobuf/descriptor_lite.hdeps/protobuf/src/google/protobuf/duration.pb.ccdeps/protobuf/src/google/protobuf/duration.pb.hdeps/protobuf/src/google/protobuf/dynamic_message.ccdeps/protobuf/src/google/protobuf/dynamic_message.hdeps/protobuf/src/google/protobuf/empty.pb.ccdeps/protobuf/src/google/protobuf/empty.pb.hdeps/protobuf/src/google/protobuf/endian.hdeps/protobuf/src/google/protobuf/explicitly_constructed.hdeps/protobuf/src/google/protobuf/extension_set.ccdeps/protobuf/src/google/protobuf/extension_set.hdeps/protobuf/src/google/protobuf/extension_set_heavy.ccdeps/protobuf/src/google/protobuf/extension_set_inl.hdeps/protobuf/src/google/protobuf/feature_resolver.ccdeps/protobuf/src/google/protobuf/feature_resolver.hdeps/protobuf/src/google/protobuf/field_access_listener.hdeps/protobuf/src/google/protobuf/field_mask.pb.ccdeps/protobuf/src/google/protobuf/field_mask.pb.hdeps/protobuf/src/google/protobuf/field_mask.protodeps/protobuf/src/google/protobuf/field_with_arena.hdeps/protobuf/src/google/protobuf/generated_enum_reflection.hdeps/protobuf/src/google/protobuf/generated_enum_util.ccdeps/protobuf/src/google/protobuf/generated_enum_util.hdeps/protobuf/src/google/protobuf/generated_message_reflection.ccdeps/protobuf/src/google/protobuf/generated_message_reflection.hdeps/protobuf/src/google/protobuf/generated_message_tctable_decl.hdeps/protobuf/src/google/protobuf/generated_message_tctable_gen.ccdeps/protobuf/src/google/protobuf/generated_message_tctable_gen.hdeps/protobuf/src/google/protobuf/generated_message_tctable_impl.hdeps/protobuf/src/google/protobuf/generated_message_tctable_lite.ccdeps/protobuf/src/google/protobuf/generated_message_util.ccdeps/protobuf/src/google/protobuf/generated_message_util.hdeps/protobuf/src/google/protobuf/has_bits.hdeps/protobuf/src/google/protobuf/implicit_weak_message.ccdeps/protobuf/src/google/protobuf/implicit_weak_message.hdeps/protobuf/src/google/protobuf/inlined_string_field.ccdeps/protobuf/src/google/protobuf/inlined_string_field.hdeps/protobuf/src/google/protobuf/internal_metadata_locator.hdeps/protobuf/src/google/protobuf/internal_visibility.hdeps/protobuf/src/google/protobuf/io/BUILD.bazeldeps/protobuf/src/google/protobuf/io/coded_stream.ccdeps/protobuf/src/google/protobuf/io/coded_stream.hdeps/protobuf/src/google/protobuf/io/coded_stream_unittest.ccdeps/protobuf/src/google/protobuf/io/gzip_stream.ccdeps/protobuf/src/google/protobuf/io/gzip_stream.hdeps/protobuf/src/google/protobuf/io/printer.ccdeps/protobuf/src/google/protobuf/io/printer.hdeps/protobuf/src/google/protobuf/io/printer_death_test.ccdeps/protobuf/src/google/protobuf/io/printer_unittest.ccdeps/protobuf/src/google/protobuf/io/strtod.hdeps/protobuf/src/google/protobuf/io/test_zero_copy_stream.hdeps/protobuf/src/google/protobuf/io/test_zero_copy_stream_test.ccdeps/protobuf/src/google/protobuf/io/zero_copy_sink.hdeps/protobuf/src/google/protobuf/io/zero_copy_stream.hdeps/protobuf/src/google/protobuf/io/zero_copy_stream_impl.ccdeps/protobuf/src/google/protobuf/io/zero_copy_stream_impl.hdeps/protobuf/src/google/protobuf/io/zero_copy_stream_impl_lite.ccdeps/protobuf/src/google/protobuf/io/zero_copy_stream_impl_lite.hdeps/protobuf/src/google/protobuf/io/zero_copy_stream_unittest.ccdeps/protobuf/src/google/protobuf/json/BUILD.bazeldeps/protobuf/src/google/protobuf/json/internal/descriptor_traits.hdeps/protobuf/src/google/protobuf/json/internal/lexer.ccdeps/protobuf/src/google/protobuf/json/internal/parser.ccdeps/protobuf/src/google/protobuf/json/internal/unparser.ccdeps/protobuf/src/google/protobuf/json/internal/unparser_traits.hdeps/protobuf/src/google/protobuf/json/internal/untyped_message.ccdeps/protobuf/src/google/protobuf/json/internal/untyped_message.hdeps/protobuf/src/google/protobuf/json/json.hdeps/protobuf/src/google/protobuf/json/json_test.ccdeps/protobuf/src/google/protobuf/map.ccdeps/protobuf/src/google/protobuf/map.hdeps/protobuf/src/google/protobuf/map_entry.h
💤 Files with no reviewable changes (1)
- deps/protobuf/src/BUILD.bazel
✅ Files skipped from review due to trivial changes (1)
- deps/protobuf/src/google/protobuf/compiler/code_generator.h
🚧 Files skipped from review as they are similar to previous changes (4)
- deps/protobuf/.bcr/metadata.template.json
- deps/protobuf/src/google/protobuf/compiler/annotation_test_util.h
- deps/protobuf/.bazelci/presubmit.yml
- deps/protobuf/src/google/protobuf/arenaz_sampler.h
|
Hey @santigimeno can you please make sure this PR is attached to a ticket? Currently it is not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Chores