Bump the doorbell timeout to 30 seconds #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
30 seconds is ok for downstairs, but it might be an irritating user-feedback for the upstairs doors (upstairs and elevator), because people can hear the bell and might wonder why a second doorbell ring does not do anything (and we end up with destroyed buttons because people press it hard). We need to think about a better user-interaction to make that more understandable but only once we have improved terminals (I want LCD displays on all of them, and multiple LEDs for rainbow or other effects). Anyway, TL;DR: maybe we should have different auto-suppress times for gate (30s) and the rest (10s?). |
|
Are you still working on this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.