fix(cli): let child profiles override inherited allow_http2 - #1684
Draft
Frankie-Xu wants to merge 1 commit into
Draft
fix(cli): let child profiles override inherited allow_http2#1684Frankie-Xu wants to merge 1 commit into
Frankie-Xu wants to merge 1 commit into
Conversation
Contributor
PR Review SummarySize
Affected crates
Blast radius — BroadThis PR touches: source code,documentation,configuration / policy files Updated automatically on each push to this PR. |
Signed-off-by: Frankie-Xu <92643488+Frankie-Xu@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Frankie-Xu
force-pushed
the
fix/1632-http2-profile-override
branch
from
August 21, 2026 06:38
66217ed to
64100bd
Compare
Contributor
Author
|
Rebased onto latest |
Frankie-Xu
marked this pull request as draft
August 21, 2026 10:56
Contributor
Author
|
Putting this back to draft so I stay within the 1–2 open PR limit. Clippy failed after the rebase onto main; I'll deal with that while it's a draft. No review needed right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #1632
Summary
Fix profile inheritance for
network.allow_http2: the field was OR-merged (base || child), so any ancestor withallow_http2: truepermanently forced HTTP/2 on all descendants. A child setting"allow_http2": falsewas silently ignored.This PR changes
allow_http2toInheritableValue<bool>(same three-state model asnetwork_profile): absent inherits, explicittrue/falseoverrides,nullclears an inheritedtrue. Call sites useresolved_allow_http2(); the CLI--allow-http2flag is still OR'd with the resolved profile value at launch (unchanged).Files consulted:
crates/nono-cli/src/profile/mod.rs(merge_profiles,InheritableValue),sandbox_prepare.rs,proxy_command.rs,nono-profile.schema.json,profile-authoring-guide.md,docs/cli/features/networking.mdx.Agent Disclosure
This PR is submitted by an AI coding agent (Cursor AI) on behalf of @Frankie-Xu, per
AGENTS.md/CLAUDE.md. Intent and approach were disclosed in #1632 (comment). The change is CLI profile merge only; no library policy changes. This contribution complies with repository coding and security requirements.Test Plan
make ci(clippy, fmt-check, tests, cargo audit, lint-aliases, lint-docs) — passed locally on macOSextendsprofile loadingproxy_commandtests: childfalseoverrides inheritedtrue; CLI--allow-http2still ORs with resolved profilefalseallow_http2accepts boolean or nullChecklist
Agent Compliance Check (Required for AI/Automated PRs)
Made with Cursor