Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user option to scale the text down #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fleutot
Copy link

@fleutot fleutot commented Mar 8, 2018

No description provided.

@nomeata
Copy link
Owner

nomeata commented Mar 8, 2018

Hi, and thanks. This needs also documentation in the manpage:
https://github.com/nomeata/screen-message/blob/master/sm.6

I usually do scaling by adding spaces before and after, which works intuitive, you can do it even after you have started it and does not need extra options (I like to avoid becoming sm a beast with an endless list options). Do you think this option is really needed?

@nomeata
Copy link
Owner

nomeata commented Mar 8, 2018

Also, the option parser might want to complain if the argument is not a valid floating point number; and I am not sure if allowing 0.0 is useful.

@fleutot
Copy link
Author

fleutot commented Mar 8, 2018

Fine, I understand your point of view!

@nomeata
Copy link
Owner

nomeata commented Mar 8, 2018

Well, my point of view is not unchangeable :-). Maybe we’ll see if more users request this feature.

@SolidTux
Copy link

SolidTux commented Mar 9, 2018

I think a scaling feature would be useful, but not really as a command line option. Maybe some shortcut like ctrl + and ctrl -?

@fleutot
Copy link
Author

fleutot commented Mar 9, 2018

@SolidTux I was planning to use sm on a remote machine, so I couldn't use a shortcut solution.

@fleutot
Copy link
Author

fleutot commented Mar 9, 2018

@nomeata 0.0 is not useful, but I did not want to set an arbitrary limit (decide for the user when a scaling factor is too small). If someone tries to use 0.0 and gets no text, it's on them.

@SolidTux
Copy link

SolidTux commented Mar 9, 2018

Why don't you check for <= 0 instead of < 0?

@nomeata
Copy link
Owner

nomeata commented Mar 10, 2018

For --invert we also have a key command. So I agree: If this is implemented, then maybe we want both flags and keys. But if we want keys, we also need a key combination to reset it to zoom-to-fit. Which key combo is appropriate there?

@SolidTux
Copy link

What about ctrl+0? That works in Firefox and Chrome so it would be at least somehow familiar.

@nomeata
Copy link
Owner

nomeata commented Mar 10, 2018

Sounds good, it’s what I would expect as well.

@fleutot
Copy link
Author

fleutot commented Mar 11, 2018

Reset to scaling 1.0, or to scaling argument on command line?
I agree on <= 0.

@nomeata
Copy link
Owner

nomeata commented Mar 11, 2018

Reset to scaling 1.0, or to scaling argument on command line?

That’s a corner case… to command line, I’d say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants