-
Notifications
You must be signed in to change notification settings - Fork 82
Complete GCP namespace support #7836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
2aea9d0
to
1d8bd81
Compare
a89dccb
to
4522b53
Compare
e7d6cea
to
13dfda0
Compare
13dfda0
to
93cf515
Compare
84a7178
to
175cac3
Compare
ec8835e
to
7eeb771
Compare
2c1716a
to
1dc47c5
Compare
6547d9b
to
7f71f4c
Compare
7f71f4c
to
933d3e4
Compare
78c3acf
to
0e3525a
Compare
Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben <[email protected]>
- Fix invalid call to stats collector Signed-off-by: Ben <[email protected]>
- Explain why an S3 client is used Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben <[email protected]>
- Remove `else` branch by adding an early exit Signed-off-by: Ben <[email protected]>
2c6f02c
to
21966be
Compare
This PR had no activity for too long - it will now be labeled stale. Update it to prevent it from getting closed. |
Keep active... |
This PR had no activity for too long - it will now be labeled stale. Update it to prevent it from getting closed. |
Not today, github-actions <3 |
This PR had no activity for too long - it will now be labeled stale. Update it to prevent it from getting closed. |
Bad github-actions, bad! |
Explain the changes
I opted to use AWS SDK v3 for posterity, and went with barebones commands to speed things up a bit,
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
I tested the PR locally with multipart uploads, as well as addition and removal of object metadata