Skip to content

Remove root key mentions from the core YAML #8942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Neon-White
Copy link
Contributor

@Neon-White Neon-White commented Apr 7, 2025

Describe the Problem

In continuation to noobaa/noobaa-operator#1533 (which also contains a more elaborate explanation), this PR removes the references to the env var in the core YAMLs.

Issues:

Fixes:

  1. DFBUGS-1608

Testing Instructions:

  1. Deploy NooBaa
  2. Perform some day 1 operations (bucket creation, bucket IO)
  • Doc added/updated
  • Tests added

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/test/unit_tests/test_encryption.js:906

  • Verify that the removal of the subsequent load calls (previously used to reload the system state) does not leave the active root key state unvalidated. Consider adding explicit assertions to ensure that the state update is properly reflected after modifying the active root key file.
await fs.promises.writeFile(config.ROOT_KEY_MOUNT + '/active_root_key', 'key1');

src/server/system_services/master_key_manager.js:52

  • Confirm that the revised get_root_key_id behavior (which now solely relies on this.active_root_key) correctly handles cases when active_root_key is undefined, since the environment variable fallback was removed.
return this.active_root_key && this.active_root_key.toString();

@Neon-White Neon-White marked this pull request as draft April 7, 2025 19:44
@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 14, 2025
@Neon-White Neon-White force-pushed the remove-root-secret-env-dead-code branch from 9e76432 to 751a904 Compare April 14, 2025 17:34
@Neon-White Neon-White force-pushed the remove-root-secret-env-dead-code branch 2 times, most recently from a8cea44 to 1f0ad13 Compare May 12, 2025 17:00
@pull-request-size pull-request-size bot added size/S and removed size/M labels May 12, 2025
@Neon-White Neon-White force-pushed the remove-root-secret-env-dead-code branch from 84e9463 to e7d11a3 Compare May 13, 2025 09:09
@pull-request-size pull-request-size bot added size/M and removed size/S labels May 13, 2025
@Neon-White Neon-White force-pushed the remove-root-secret-env-dead-code branch from 329e47b to 1f0ad13 Compare May 13, 2025 10:02
@Neon-White Neon-White force-pushed the remove-root-secret-env-dead-code branch from ca64994 to 1f0ad13 Compare May 14, 2025 10:15
@pull-request-size pull-request-size bot added size/S and removed size/L labels May 14, 2025
@Neon-White Neon-White changed the title Remove root key env var dead code Remove root key env var from the core YAML May 14, 2025
@Neon-White Neon-White marked this pull request as ready for review May 14, 2025 10:16
@Neon-White Neon-White changed the title Remove root key env var from the core YAML Remove root key mentions from the core YAML May 15, 2025
@Neon-White Neon-White force-pushed the remove-root-secret-env-dead-code branch from 1f0ad13 to d0dbbcd Compare May 16, 2025 13:36
@Neon-White Neon-White force-pushed the remove-root-secret-env-dead-code branch from d0dbbcd to ea78614 Compare May 20, 2025 06:58
@Neon-White Neon-White merged commit 12dc377 into noobaa:master May 20, 2025
11 checks passed
@Neon-White Neon-White deleted the remove-root-secret-env-dead-code branch May 20, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants