NC | supplemental groups - getpwuid concurrency issue #9010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guymguym
reviewed
May 6, 2025
nadavMiz
force-pushed
the
supplemental_groups_concurrency
branch
from
7d93074 to
48e9f77
Compare
Signed-off-by: nadav mizrahi <[email protected]>
nadavMiz
force-pushed
the
supplemental_groups_concurrency
branch
from
48e9f77 to
bbb348c
Compare
romayalon
reviewed
May 12, 2025
| @@ -41,6 +41,16 @@ class ThreadScope | |||
| change_user(); | |||
| } | |||
|
|
|||
| static void set_passwd_buf_size(int buf_size) | |||
There was a problem hiding this comment.
Suggested change
| static void set_passwd_buf_size(int buf_size) | |
| static void set_passwd_buf_size(long buf_size) |
| @@ -2419,7 +2419,7 @@ fs_napi(Napi::Env env, Napi::Object exports) | |||
| if (passwd_bufsize == -1) { | |||
| passwd_bufsize = 16384; | |||
| } | |||
| PASSWD_BUF_SIZE = passwd_bufsize; | |||
| ThreadScope::set_passwd_buf_size(passwd_bufsize); | |||
There was a problem hiding this comment.
we should move lines 2418 - 2421 inside set_passwd_buf_size()
although I must say it's a bit weird to set this static size per thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Problem
as noted in #8982 : getpwuid function is not thread safe. so need to replace with thread safe getpwuid_r
Explain the Changes
Issues: Fixed #8985
GAP - need to test on macos environment
Testing Instructions:
sudo NC_CORETEST=true node ./node_modules/mocha/bin/mocha src/test/unit_tests/test_nsfs_access.js