Skip to content

Small bug fixes and refactors - #117

Draft
norberttak wants to merge 10 commits into
masterfrom
bugfixes
Draft

Small bug fixes and refactors#117
norberttak wants to merge 10 commits into
masterfrom
bugfixes

Conversation

@norberttak

@norberttak norberttak commented Jun 9, 2026

Copy link
Copy Markdown
Owner
  1. Memory leak in ClassConfiguration::clear()
  2. ClassConfiguration::operator= appends instead of replacing
  3. Partially initialized Action constructors
  4. Uninitialized variables in FIP image layer parsing
  5. Use std::lock_guard instead of manual lock()/unlock()
  6. Duplicate #include directives in Device.h
  7. Device.h: move the use std::literals into c++ files
  8. Typo in LuaHelper::get_instace()
  9. Naming inconsistency: Configparser vs ConfigParser
  10. Add error handling around USB HID open functions

@norberttak norberttak self-assigned this Jun 9, 2026
@norberttak norberttak added the bug Something isn't working label Jun 9, 2026
@norberttak
norberttak marked this pull request as draft June 9, 2026 16:10
@norberttak norberttak added this to the v1.10 milestone Jun 9, 2026
@norberttak
norberttak force-pushed the bugfixes branch 3 times, most recently from 4a326f1 to 0a76964 Compare June 10, 2026 05:34
@norberttak
ClassConfiguration: fix the memory leak in clean() function
2f9cc89 
Signed-off-by: Norbert Takacs <norberttak@gmail.com>
@norberttak
ClassConfiguration: clear previosuly set data in operator = before ne…
743d9eb 
…w assignment

Signed-off-by: Norbert Takacs <norberttak@gmail.com>
@norberttak
Action class: cleanup the data initialization inside the constructors
f4d1b59 
Signed-off-by: Norbert Takacs <norberttak@gmail.com>
@norberttak
ConfigParser class: initialize variables in process_fip_layer_section
2155bc9 
Signed-off-by: Norbert Takacs <norberttak@gmail.com>
@norberttak
Use lock_guard to avoid unreleased mutexes
afabe47 
Signed-off-by: Norbert Takacs <norberttak@gmail.com>
@norberttak
include and using:
e3fad54 
Remove duplicated inlude. Move using directive from device.h into c++ files

Signed-off-by: Norbert Takacs <norberttak@gmail.com>
@norberttak
fix typo in LuaHelper.h: get_instace -> get_instance
84b1998 
Signed-off-by: Norbert Takacs <norberttak@gmail.com>
@norberttak
rename Configparser to ConfigParser
b504710 
Signed-off-by: Norbert Takacs <norberttak@gmail.com>
@norberttak
USB HID initialization: add error handling
c4b0bc4 
Signed-off-by: Norbert Takacs <norberttak@gmail.com>
@norberttak
norberttak force-pushed the bugfixes branch 2 times, most recently from 768338b to fcab54b Compare July 28, 2026 13:04
@norberttak
mock_hid_api: add test_hid_read_wait_for_event function
de0762c 
Signed-off-by: Norbert Takacs <norberttak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@norberttak norberttak

Labels

bug Something isn't working

Projects

None yet

Milestone

v1.10

Development

Successfully merging this pull request may close these issues.

1 participant

@norberttak