Fixed incorrect tab formatting when 'window_activity_flag' is set on window#91
Open
QuocAnhVu wants to merge 1 commit intonordtheme:developfrom
Open
Fixed incorrect tab formatting when 'window_activity_flag' is set on window#91QuocAnhVu wants to merge 1 commit intonordtheme:developfrom
QuocAnhVu wants to merge 1 commit intonordtheme:developfrom
Conversation
Author
|
Related: tmux/tmux#3927 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is a process running on another tab, currently the default behavior in tmux is to swap fg and bg colors, causing tabs to look like this:
The second tab has activity and has flipped colors.
One workaround is to set
window-status-activity-styleto an empty string to disable the color inversion. This is safe becausewindow-status-activity-styleis ignored whenwindow-status-formatis set.The second tab has activity but no visual signifier.
To improve on this, we can make use of conditionals to bold activity text.
The second tab has activity and is bolded.
The third figure is the fix and functionality that this pull request provides.